Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1650773003: Revert of [Cronet] Get Cronet performance test running again (Closed)

Created:
4 years, 10 months ago by jbroman
Modified:
4 years, 10 months ago
Reviewers:
pauljensen, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cronet] Get Cronet performance test running again (patchset #13 id:240001 of https://codereview.chromium.org/1536433002/ ) Reason for revert: Broke Android (failed in proguard obfuscation on cronet_perf_test_apk): https://build.chromium.org/p/chromium/builders/Android/builds/51325 Original issue's description: > [Cronet] Get Cronet performance test running again > > 1. Enable HTTPS for QUIC > a. Insert a MockCertVerifier to pretend our cert is in root store > b. Insert HostResolver rules to pretend test.example.com resolves > to the the IP address of the USB reverse-tether interface > c. Switch from using libcronet.so to libcronet_test.so as it > contains several utilities we need (e.g. MockCertVerifier). > This required making a Cronet testing Java target. > d. Pass private key and cert to quic_server > e. Copy cert to device > 2. Call PathUtils.setPrivateDataDirectorySuffix() to avoid crash > 3. Modify proguard options to avoid crbug.com/488192 > 4. Make Telemetry happy again > a. Put basic header in config file > b. Specify default_chrome_root > 5. Avoid Theme.NoDisplay as it fails with Android Marshmallow > > Committed: https://crrev.com/58f1ff598b4f96f9645574564f296f0e428f37ff > Cr-Commit-Position: refs/heads/master@{#372532} TBR=mef@chromium.org,pauljensen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fe8c97b0eefe693ee9d713e51122c63b5eb62f1e Cr-Commit-Position: refs/heads/master@{#372533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -320 lines) Patch
M components/cronet.gypi View 4 chunks +4 lines, -28 lines 0 comments Download
M components/cronet/android/BUILD.gn View 4 chunks +4 lines, -62 lines 0 comments Download
M components/cronet/android/test/cronet_test_jni.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D components/cronet/android/test/cronet_test_util.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/cronet/android/test/cronet_test_util.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M components/cronet/android/test/javaperftests/AndroidManifest.xml View 1 chunk +1 line, -4 lines 0 comments Download
D components/cronet/android/test/javaperftests/proguard.cfg View 1 chunk +0 lines, -2 lines 0 comments Download
M components/cronet/android/test/javaperftests/run.py View 6 chunks +8 lines, -23 lines 0 comments Download
M components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java View 6 chunks +5 lines, -34 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 2 chunks +7 lines, -3 lines 0 comments Download
M components/cronet/android/test/native_test_server.cc View 4 chunks +54 lines, -1 line 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java View 2 chunks +5 lines, -40 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/NativeTestServer.java View 4 chunks +24 lines, -0 lines 0 comments Download
D components/cronet/android/test/src_dummy/org/chromium/net/test/dummy/Dummy.java View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jbroman
Created Revert of [Cronet] Get Cronet performance test running again
4 years, 10 months ago (2016-01-30 05:31:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650773003/1
4 years, 10 months ago (2016-01-30 05:32:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 05:34:19 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 05:35:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe8c97b0eefe693ee9d713e51122c63b5eb62f1e
Cr-Commit-Position: refs/heads/master@{#372533}

Powered by Google App Engine
This is Rietveld 408576698