Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165073002: Remove deprecated version of views::CreateDialogFrameView. (Closed)

Created:
6 years, 10 months ago by msw
Modified:
6 years, 10 months ago
Reviewers:
Mike Wittman, Lei Zhang, sky
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, benquan, tfarina, benjhayden+dwatch_chromium.org, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Remove deprecated version of views::CreateDialogFrameView. Patch Set 1 here is Lei's original patch: https://codereview.chromium.org/109623005/ That was reverted for causing http://crbug.com/343042 This performs the same cleanup without the print preview regression. (keeps ConstrainedWebDialogDelegateViewViews::CreateNonClientFrameView) BUG=166075 TEST=No behavior/appearance changes; no dialog frame regressions (print preview or otherwise). TBR=wittman@chromium.org,sky@chromium.org,thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251243

Patch Set 1 : Original patch from https://codereview.chromium.org/109623005 #

Patch Set 2 : Restore ConstrainedWebDialogDelegateViewViews::CreateNonClientFrameView. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -177 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 4 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/download/download_danger_prompt_views.cc View 6 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/pdf_password_dialog.cc View 5 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.h View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 2 chunks +3 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Please take a look as you have time; landing.
6 years, 10 months ago (2014-02-13 23:35:46 UTC) #1
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-13 23:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/165073002/50001
6 years, 10 months ago (2014-02-13 23:37:21 UTC) #3
Lei Zhang
lgtm
6 years, 10 months ago (2014-02-14 01:00:49 UTC) #4
commit-bot: I haz the power
Change committed as 251243
6 years, 10 months ago (2014-02-14 03:37:21 UTC) #5
Mike Wittman
6 years, 10 months ago (2014-02-14 16:46:12 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698