Issue 165067: Remove the Mac-specific implementation of LaunchApp, and share the Linux version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165067: Remove the Mac-specific implementation of LaunchApp, and share the Linux version. (Closed)

Created:
11 years, 4 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove the Mac-specific implementation of LaunchApp, and share the Linux version. Fixes a race condition with file descriptors, and gives the Mac access to the environment-alterning version of LaunchApp BUG=11174 TEST=Launching render/plugin/utility processes should still work on the Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22649

Patch Set 1 #

Patch Set 2 : Removing stray files from patch #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -151 lines)			Patch
M	base/process_util.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	base/process_util_linux.cc	View	2 chunks	+0 lines, -77 lines	0 comments	Download
M	base/process_util_mac.mm	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	base/process_util_posix.cc	View	1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages