Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1650653002: SkNx Load/store: take any pointer. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkNx Load/store: take any pointer. This means we can remove a lot of explicit casts in code that uses SkNx. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650653002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/507ef6d68115ae9e6d884bb36436a1463523d893

Patch Set 1 #

Patch Set 2 : simplify call sites #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -82 lines) Patch
M bench/Sk4fBench.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkColor.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkGeometry.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkMipMap.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkNx.h View 3 chunks +12 lines, -4 lines 0 comments Download
M src/core/SkRect.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkColorCubeFilter_opts.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/opts/SkMatrix_opts.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M src/opts/SkNx_avx.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/SkNx_neon.h View 8 chunks +16 lines, -16 lines 0 comments Download
M src/opts/SkNx_sse.h View 9 chunks +19 lines, -19 lines 0 comments Download
M src/opts/SkXfermode_opts.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650653002/20001
4 years, 10 months ago (2016-01-29 20:03:52 UTC) #4
mtklein_C
4 years, 10 months ago (2016-01-29 20:13:41 UTC) #6
reed1
lgtm
4 years, 10 months ago (2016-01-29 20:58:11 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-30 17:59:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650653002/20001
4 years, 10 months ago (2016-01-31 15:49:35 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-31 16:02:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/507ef6d68115ae9e6d884bb36436a1463523d893

Powered by Google App Engine
This is Rietveld 408576698