Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1650633003: GN: Use special toolchain for nacl64.exe, force is_component_build off (Closed)

Created:
4 years, 10 months ago by Roland McGrath
Modified:
4 years, 10 months ago
Reviewers:
*Dirk Pranke, *bradnelson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use special toolchain for nacl64.exe, force is_component_build off The nacl64.exe build within the Windows 32-bit x86 Chrome build is not compatible with component-style builds. Build nacl64.exe in a special variant of the x64 toolchain, wherein is_component_build is always false. BUG=512869 CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel,win_clang_dbg Committed: https://crrev.com/b69e64de8c10dee033d42e8cd92dcca6f2f81411 Cr-Commit-Position: refs/heads/master@{#372485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -20 lines) Patch
M build/toolchain/win/BUILD.gn View 2 chunks +56 lines, -16 lines 0 comments Download
M components/nacl/broker/BUILD.gn View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Roland McGrath
This is a reland of crrev.com/372217, which got reverted due to a trivial gn problem ...
4 years, 10 months ago (2016-01-29 21:25:48 UTC) #3
Dirk Pranke
lgtm
4 years, 10 months ago (2016-01-29 21:40:30 UTC) #4
bradnelson
lgtm
4 years, 10 months ago (2016-01-29 23:25:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650633003/1
4 years, 10 months ago (2016-01-29 23:27:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 00:12:08 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 00:13:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b69e64de8c10dee033d42e8cd92dcca6f2f81411
Cr-Commit-Position: refs/heads/master@{#372485}

Powered by Google App Engine
This is Rietveld 408576698