Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1650623004: Add Test for field.getArray() sort-order. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Test for field.getArray() sort-order. One more test before replacing the old sort() mechanism. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/56d618ac9b4c82a9a350f21bbc6ec2ec6a95c8b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
A testing/resources/javascript/field.in View 1 chunk +126 lines, -0 lines 0 comments Download
A testing/resources/javascript/field_expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
For review.
4 years, 10 months ago (2016-01-30 01:11:04 UTC) #1
Lei Zhang
lgtm
4 years, 10 months ago (2016-01-30 01:14:06 UTC) #2
Tom Sepez
4 years, 10 months ago (2016-02-01 18:08:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56d618ac9b4c82a9a350f21bbc6ec2ec6a95c8b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698