Recognize standard character classes and implement more efficient matchers.

Recognizes character classes like whitespace and non-newline and generates more efficient code.

[Lasse Reichstein, 2009-01-02 10:27:48]

This change only really optimizes matching of whitespace yet.
Code-review please.

[Mads Ager (chromium), 2009-01-02 10:45:16]

LGTM

http://codereview.chromium.org/16506/diff/201/401
File src/ast.h (right):

http://codereview.chromium.org/16506/diff/201/401#newcode706
Line 706: // used for minimizing the work when constructing it at runtime.
used used -> used

http://codereview.chromium.org/16506/diff/201/401#newcode1313
Line 1313: uc16 standard_set_type_;
Why not just type?

I find the standard_set_type/special_set_type naming confusing.

http://codereview.chromium.org/16506/diff/201/402
File src/jsregexp.cc (right):

http://codereview.chromium.org/16506/diff/201/402#newcode1748
Line 1748: cp_offset, check_offset,
I would put one argument per line here.

http://codereview.chromium.org/16506/diff/201/402#newcode3390
Line 3390: if (ranges->length() != (length>>1)+1) {
Space around the binary operators?

http://codereview.chromium.org/16506/diff/201/402#newcode3401
Line 3401: range = ranges->at((i>>1)+1);
Space around the binary operators?

http://codereview.chromium.org/16506/diff/201/402#newcode3402
Line 3402: if (special_class[i+1] != range.from() - 1) {
Space around the binary operator?

http://codereview.chromium.org/16506/diff/201/402#newcode3419
Line 3419: for (int i = 0; i < length; i+=2) {
Space around the '+=' for consistency?

http://codereview.chromium.org/16506/diff/201/405
File src/regexp-macro-assembler-tracer.cc (right):

http://codereview.chromium.org/16506/diff/201/405#newcode313
Line 313: "check_offset=%s, label[%08x]): %s;\n",
Indentation off by 2 here?

[Mads Ager (chromium), 2009-01-02 10:51:06]

One additional comment.

http://codereview.chromium.org/16506/diff/201/403
File src/regexp-macro-assembler-ia32.cc (right):

http://codereview.chromium.org/16506/diff/201/403#newcode409
Line 409: bool RegExpMacroAssemblerIA32::CheckSpecialCharacterClass(uc16 type,
A lot of unnamed constants are used in this code and it is not obvious to me
what is going on.  I think each of the cases in the switch should have a comment
explaining what is going on.