Issue 1650493003: Merge to XFA: Refactor CPDF_Object and its subclasses.

Issue 1650493003: Merge to XFA: Refactor CPDF_Object and its subclasses. (Closed)

Created:
4 years, 10 months ago by Wei Li

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Refactor CPDF_Object and its subclasses. Mainly use virtual functions to replace functions with switch statements. Also remove a few unused functions and make some format changes. BUG=pdfium:63 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1634373003 . (cherry picked from commit df1ab41e000069dda7bf21527308f3bf41e126ca) Committed: https://pdfium.googlesource.com/pdfium/+/8f952279866afb647b7098c0cbdc25e35e8c0531

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+600 lines, -699 lines)			Patch
M	core/include/fpdfapi/fpdf_objects.h	View	11 chunks	+230 lines, -210 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View	40 chunks	+130 lines, -464 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp	View	7 chunks	+239 lines, -24 lines	0 comments	Download

Total messages: 5 (2 generated)

Wei Li

Clean merge except the unit test file which has some name changes. TBR.

4 years, 10 months ago (2016-01-30 02:03:48 UTC) #2

Wei Li

Committed patchset #1 (id:1) manually as 8f952279866afb647b7098c0cbdc25e35e8c0531 (presubmit successful).

4 years, 10 months ago (2016-01-30 02:04:48 UTC) #4

Message was sent while issue was closed.

lgtm