Alt+E is the Windows Task Manager shortcut for killing a process. Adding the ...

Alt+E is the Windows Task Manager shortcut for killing a process. Adding the extra Accelerator to handle this shortcut.

BUG=7229
TEST=none

[Peter Kasting, 2009-08-06 20:11:10]

I don't think I'm the right reviewer for this.  Punting to Ben to find someone.

I would have two questions:
(1) Why do we say "Alt-E/E" when for all the other commands that have multiple
shortcuts we just pick one to display?
(2) Why are the accelerators and strings here hardcoded into the file instead of
living in a resources file (even if not localized, usually accelerators would be
in some .rc or something)?

[pierre.lafayette, 2009-08-10 16:52:18]

Please review.

[pierre.lafayette, 2009-08-15 14:02:05]

Hi Erik,
Noticed your working today. This review has been pending for a while now. Can
you please take a look?

[Erik does not do reviews, 2009-08-15 14:09:24]

On Sat, Aug 15, 2009 at 7:02 AM, <pierre.lafayette@gmail.com> wrote:
> Hi Erik,
> Noticed your working today. This review has been pending for a while
> now. Can you please take a look?

Hi Pierre,

While the change seems reasonable to me, I'm likely the wrong person
to address the questions that Peter brought up about whether keyboard
shortcuts should be pulled into a resource file.  Ben or Glen are your
best bets (or at least they could help you find the right person).

Erik


> http://codereview.chromium.org/165049
>

[pierre.lafayette, 2009-08-15 14:26:22]

Hi Glen,
Can you take a look at this?

[pierre.lafayette, 2009-09-04 16:05:01]

ping.

[Glen Murphy, 2009-09-08 22:40:35]

It seems that removing SetAccessibleKeyboardShortcut causes a bunch of
accessibility stuff to no-longer exist - can you comment on why this was
removed? I don't mind adding shortcuts, but taking them away is a bigger deal.

[Glen Murphy, 2009-09-08 22:42:27]

Ignore that - I just read about the 'e'. This change LGTM - I won't be able to
patch it in for a while however.

[pierre.lafayette, 2009-09-18 19:29:33]

ping.

On 2009/09/08 22:42:27, Glen Murphy wrote:
> Ignore that - I just read about the 'e'. This change LGTM - I won't be able to
> patch it in for a while however.

[pierre.lafayette, 2009-10-06 21:20:13]

ping^2