chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm - Issue 1650483002: Refactor: Untangle Mac's ExclusiveAccessContext from BrowserWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm

Issue 1650483002: Refactor: Untangle Mac's ExclusiveAccessContext from BrowserWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename accessor Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm ('k') | chrome/browser/ui/exclusive_access/exclusive_access_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm

index 929d9a6dc86135f587818b773396f54bde96d589..7b7717b1bcc123ba4d155294a91e5a8fec1592e9 100644

--- a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm

@@ -7,6 +7,7 @@

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h"

#include "chrome/browser/ui/cocoa/browser_window_controller.h"

#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -109,17 +110,17 @@ TEST_F(ExclusiveAccessBubbleWindowControllerTest,

ASSERT_TRUE(browser()->window()->IsFullscreen());

}

- ExclusiveAccessBubbleWindowController* bubble =

- [bwc exclusiveAccessBubbleWindowController];

- EXPECT_TRUE(bubble);

+ ExclusiveAccessController* access_controller =

+ [bwc exclusiveAccessController];

+ EXPECT_TRUE(access_controller->cocoa_bubble());

{

content::WindowedNotificationObserver fullscreen_observer(

chrome::NOTIFICATION_FULLSCREEN_CHANGED,

content::NotificationService::AllSources());

- [bubble deny:nil];

+ [access_controller->cocoa_bubble() deny:nil];

fullscreen_observer.Wait();

}

- EXPECT_FALSE([bwc exclusiveAccessBubbleWindowController]);

+ EXPECT_FALSE(access_controller->cocoa_bubble());

EXPECT_FALSE(browser()->window()->IsFullscreen());

CloseBrowserWindow();

}