Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5972)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 1650483002: Refactor: Untangle Mac's ExclusiveAccessContext from BrowserWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self nits, More robust interface, fix other random stuff Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.h
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h
index 4d9d9d2472a278d4a5ea227da3ea7d7168f57b34..242e0b0e8bb870b60f5bc373b08c992a9af0deaf 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h
@@ -10,7 +10,6 @@
#include "chrome/browser/extensions/extension_keybinding_registry.h"
#include "chrome/browser/signin/chrome_signin_helper.h"
#include "chrome/browser/ui/browser_window.h"
-#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
#include "chrome/browser/ui/search/search_model_observer.h"
#include "chrome/browser/ui/tabs/tab_utils.h"
#include "components/bookmarks/browser/bookmark_model.h"
@@ -36,7 +35,6 @@ class Extension;
class BrowserWindowCocoa
: public BrowserWindow,
- public ExclusiveAccessContext,
public extensions::ExtensionKeybindingRegistry::Delegate,
public SearchModelObserver {
public:
@@ -78,22 +76,9 @@ class BrowserWindowCocoa
void Maximize() override;
void Minimize() override;
void Restore() override;
- void EnterFullscreen(const GURL& url,
- ExclusiveAccessBubbleType type,
- bool with_toolbar) override;
- void ExitFullscreen() override;
- void UpdateExclusiveAccessExitBubbleContent(
- const GURL& url,
- ExclusiveAccessBubbleType bubble_type) override;
- void OnExclusiveAccessUserInput() override;
bool ShouldHideUIForFullscreen() const override;
bool IsFullscreen() const override;
bool IsFullscreenBubbleVisible() const override;
- bool SupportsFullscreenWithToolbar() const override;
- void UpdateFullscreenWithToolbar(bool with_toolbar) override;
- void ToggleFullscreenToolbar() override;
- bool IsFullscreenWithToolbar() const override;
- bool ShouldHideFullscreenToolbar() const override;
LocationBar* GetLocationBar() const override;
void SetFocusToLocationBar(bool select_all) override;
void UpdateReloadStopState(bool is_loading, bool force) override;
@@ -170,12 +155,6 @@ class BrowserWindowCocoa
const extensions::Command& command) override;
ExclusiveAccessContext* GetExclusiveAccessContext() override;
- // ExclusiveAccessContext interface
- Profile* GetProfile() override;
- content::WebContents* GetActiveWebContents() override;
- void UnhideDownloadShelf() override;
- void HideDownloadShelf() override;
-
// Overridden from ExtensionKeybindingRegistry::Delegate:
extensions::ActiveTabPermissionGranter* GetActiveTabPermissionGranter()
override;

Powered by Google App Engine
This is Rietveld 408576698