Move DOM-inspecting language detection logic to Blink.

Move DOM-inspecting language detection logic to Blink.

This is a rewrite of the functionality, along with the tests,
not a straight-up move.

BUG=521166

[dglazkov, 2016-01-30 00:52:53]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-30 00:53:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650303002/1

[commit-bot: I haz the power, 2016-01-30 01:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 01:11:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dglazkov, 2016-01-30 04:57:47]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-30 04:58:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650303002/20001

[commit-bot: I haz the power, 2016-01-30 05:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 05:39:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dglazkov, 2016-01-30 05:51:07]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-30 05:51:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650303002/40001

[commit-bot: I haz the power, 2016-01-30 07:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 07:14:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dglazkov, 2016-01-31 05:22:05]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-01-31 05:22:06]

Removed wishful-thinking assertion.

[commit-bot: I haz the power, 2016-01-31 05:22:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650303002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650303002/60001

[commit-bot: I haz the power, 2016-01-31 06:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-31 06:33:34]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-02-05 21:36:35]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-02-05 21:36:39]

Wrote tests.

[commit-bot: I haz the power, 2016-02-05 21:37:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650303002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650303002/80001

[commit-bot: I haz the power, 2016-02-05 21:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 21:42:08]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dglazkov, 2016-02-05 22:32:46]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-02-05 22:32:47]

Rebased.

[commit-bot: I haz the power, 2016-02-05 22:36:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650303002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650303002/100001

[commit-bot: I haz the power, 2016-02-05 23:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 23:47:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-02-06 01:44:34]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-02-06 01:44:36]

I've been trying to decide if I want services to be accessible by way of
something like FooService::Get(document or frame or thing), or if they should
just be all static and you access them by creating one on a stack. Hmm..

https://codereview.chromium.org/1650303002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp (right):

https://codereview.chromium.org/1650303002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp:318: inline
static bool hasNoTranslateMeta(Document& document)
I doubt you want this inline

https://codereview.chromium.org/1650303002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebLanguageDetectionDetails.h (right):

https://codereview.chromium.org/1650303002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebLanguageDetectionDetails.h:21: bool
hasNoTranslateMeta;
I think you can actually just write = false; here and remove the constructor

https://codereview.chromium.org/1650303002/diff/80001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebDocument.h (right):

https://codereview.chromium.org/1650303002/diff/80001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebDocument.h:140: BLINK_EXPORT
WebLanguageDetectionDetails languageDetectionDetails();
I think maybe we want a DocumentFeatureService that takes a WebDocument as an
argument and has the methods for vending this data.

I'm not sure how to enforce that services are ephemeral yet.