Fix issue 5806. If the suggest server returns a NAVIGATION...

Fix issue 5806. If the suggest server returns a NAVIGATION
link without a scheme, default the scheme to http. This 
prevents empty items from showing up in the completion
list.

BUG=5806

[Brian Duff, 2009-01-06 05:58:34]

(Comments weren't in codereview, so summarizing them here...)

> Any reason not to just always call FixupURL()?  

Done.

> I wonder if we should sanity-check the results of this stuff, too, to avoid
pushing bogus entries into the list.

According to url_fixer_upper.h, "The result will be a 'more' valid URL than the
input. It may still not be valid, convert to a GURL for that.". So I made the
code check GURL.is_valid().

[Peter Kasting, 2009-01-06 18:32:31]

LGTM with nits fixed.

http://codereview.chromium.org/16503/diff/205/206
File chrome/browser/autocomplete/search_provider.cc (right):

http://codereview.chromium.org/16503/diff/205/206#newcode325
Line 325: // Navigation links might not be valid URLs. For example,
Nit: Make sure your comment lines go as far towards 80 columns as possible
before wrapping

http://codereview.chromium.org/16503/diff/205/206#newcode326
Line 326: // the google suggest server returns navigation links without
Nit: Capitalize "Google"

http://codereview.chromium.org/16503/diff/205/206#newcode327
Line 327: // a protocol if the protocol is http. Fix the URL, and verify
Nit: "protocol" -> "scheme"

http://codereview.chromium.org/16503/diff/205/206#newcode330
Line 330: if (result_url.is_valid())
Nit: Since the body of this conditional takes two physical lines, use {}

[Brian Duff, 2009-01-08 05:34:07]

http://codereview.chromium.org/16503/diff/205/206
File chrome/browser/autocomplete/search_provider.cc (right):

http://codereview.chromium.org/16503/diff/205/206#newcode325
Line 325: // Navigation links might not be valid URLs. For example,
On 2009/01/06 18:32:32, pkasting wrote:
> Nit: Make sure your comment lines go as far towards 80 columns as possible
> before wrapping

Done.

http://codereview.chromium.org/16503/diff/205/206#newcode326
Line 326: // the google suggest server returns navigation links without
On 2009/01/06 18:32:32, pkasting wrote:
> Nit: Capitalize "Google"

Done.

http://codereview.chromium.org/16503/diff/205/206#newcode327
Line 327: // a protocol if the protocol is http. Fix the URL, and verify
On 2009/01/06 18:32:32, pkasting wrote:
> Nit: "protocol" -> "scheme"

Done.

http://codereview.chromium.org/16503/diff/205/206#newcode330
Line 330: if (result_url.is_valid())
On 2009/01/06 18:32:32, pkasting wrote:
> Nit: Since the body of this conditional takes two physical lines, use {}

Done.

[Peter Kasting, 2009-01-08 18:58:41]

Tweaked and landed in r7747.