Issue 165029: Fix a few bugs with the theme infobar:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165029: Fix a few bugs with the theme infobar: (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a few bugs with the theme infobar: * Don't animate the infobar closing and opening when switching between themes. * Don't show multiple infobars when intalling themes in rapid succession. BUG=18213 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22711

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -16 lines)			Patch
M	chrome/browser/extensions/extension_install_ui.cc	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1 chunk	+3 lines, -0 lines	2 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/views/infobars/infobar_container.h	View	1 chunk	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/views/infobars/infobar_container.cc	View	3 chunks	+30 lines, -7 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

11 years, 4 months ago (2009-08-06 15:54:49 UTC) #2

LG, nits

http://codereview.chromium.org/165029/diff/1/4
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/165029/diff/1/4#newcode404
Line 404: // Replaces one infobar with another, without any aniation in between.
spelling: animation

http://codereview.chromium.org/165029/diff/1/4#newcode405
Line 405: void ReplaceInfoBar(InfoBarDelegate* old_delegate, InfoBarDelegate*
new_delegate);
80col

Expand Messages | Collapse Messages