Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp

Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp
index cc6242711bb5028138c84912582cadb023ebe81b..96a1a0bcdda4ad42852162877acaebaeeffefc24 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp
@@ -5,8 +5,8 @@
#include "core/inspector/v8/V8ProfilerAgentImpl.h"
#include "bindings/core/v8/ScriptCallStackFactory.h"
-#include "bindings/core/v8/V8Binding.h"
#include "core/inspector/ScriptCallStack.h"
+#include "core/inspector/v8/V8StringUtil.h"
#include "wtf/Atomics.h"
#include <v8-profiler.h>
@@ -53,9 +53,9 @@ PassRefPtr<TypeBuilder::Profiler::CPUProfileNode> buildInspectorObjectFor(v8::Is
RefPtr<TypeBuilder::Array<TypeBuilder::Profiler::PositionTickInfo>> positionTicks = buildInspectorObjectForPositionTicks(node);
RefPtr<TypeBuilder::Profiler::CPUProfileNode> result = TypeBuilder::Profiler::CPUProfileNode::create()
- .setFunctionName(toCoreString(node->GetFunctionName()))
+ .setFunctionName(toWTFString(node->GetFunctionName()))
.setScriptId(String::number(node->GetScriptId()))
- .setUrl(toCoreString(node->GetScriptResourceName()))
+ .setUrl(toWTFString(node->GetScriptResourceName()))
.setLineNumber(node->GetLineNumber())
.setColumnNumber(node->GetColumnNumber())
.setHitCount(node->GetHitCount())
@@ -268,13 +268,13 @@ String V8ProfilerAgentImpl::nextProfileId()
void V8ProfilerAgentImpl::startProfiling(const String& title)
{
v8::HandleScope handleScope(m_isolate);
- m_isolate->GetCpuProfiler()->StartProfiling(v8String(m_isolate, title), true);
+ m_isolate->GetCpuProfiler()->StartProfiling(toV8String(m_isolate, title), true);
}
PassRefPtr<TypeBuilder::Profiler::CPUProfile> V8ProfilerAgentImpl::stopProfiling(const String& title, bool serialize)
{
v8::HandleScope handleScope(m_isolate);
- v8::CpuProfile* profile = m_isolate->GetCpuProfiler()->StopProfiling(v8String(m_isolate, title));
+ v8::CpuProfile* profile = m_isolate->GetCpuProfiler()->StopProfiling(toV8String(m_isolate, title));
if (!profile)
return nullptr;
RefPtr<TypeBuilder::Profiler::CPUProfile> result;

Powered by Google App Engine
This is Rietveld 408576698