Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp

Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp b/third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp
index ca612b25ed7807156578f4731ffc053006c9d8be..f830b471b0dda587a5a97e564590f08b175d2d77 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp
@@ -31,21 +31,17 @@
#include "core/inspector/v8/V8FunctionCall.h"
#include "core/inspector/v8/V8DebuggerClient.h"
+#include "core/inspector/v8/V8StringUtil.h"
#include "wtf/PassOwnPtr.h"
#include <v8.h>
namespace blink {
-static v8::Local<v8::String> v8String(v8::Isolate* isolate, const String& string)
-{
- return v8::String::NewFromUtf8(isolate, string.utf8().data(), v8::NewStringType::kNormal).ToLocalChecked();
-}
-
V8FunctionCall::V8FunctionCall(V8DebuggerClient* client, v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String& name)
: m_client(client)
, m_context(context)
- , m_name(v8String(context->GetIsolate(), name))
+ , m_name(toV8String(context->GetIsolate(), name))
, m_value(value)
{
}
@@ -57,7 +53,7 @@ void V8FunctionCall::appendArgument(v8::Local<v8::Value> value)
void V8FunctionCall::appendArgument(const String& argument)
{
- m_arguments.append(v8String(m_context->GetIsolate(), argument));
+ m_arguments.append(toV8String(m_context->GetIsolate(), argument));
}
void V8FunctionCall::appendArgument(int argument)

Powered by Google App Engine
This is Rietveld 408576698