third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js - Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js

Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/InjectedScriptManager.cpp ('k') | third_party/WebKit/Source/core/inspector/v8/JavaScriptCallFrame.h » ('j') | third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js

diff --git a/third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js b/third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js

index cd41078875d5f77063214312a75a31a68ec432a4..b94f37fe23d5d95bcce4f015bf06b98f8bb8e4e0 100644

--- a/third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js

+++ b/third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js

@@ -562,7 +562,7 @@ InjectedScript.prototype = {

if (descriptor) {

if (accessorPropertiesOnly && !("get" in descriptor || "set" in descriptor))

continue;

- if ("get" in descriptor && "set" in descriptor && name != "__proto__" && InjectedScriptHost.isDOMWrapper(object) && !doesAttributeHaveObservableSideEffectOnGet(object, name)) {

+ if ("get" in descriptor && "set" in descriptor && name != "__proto__" && InjectedScriptHost.formatAccessorsAsProperties(object) && !doesAttributeHaveObservableSideEffectOnGet(object, name)) {

descriptor.value = InjectedScriptHost.suppressWarningsAndCallFunction(function(attribute) { return this[attribute]; }, object, [name]);

descriptor.isOwn = true;

delete descriptor.get;

@@ -1025,7 +1025,7 @@ InjectedScript.prototype = {

_isHTMLAllCollection: function(object)

{

// document.all is reported as undefined, but we still want to process it.

- return (typeof object === "undefined") && InjectedScriptHost.isHTMLAllCollection(object);

+ return (typeof object === "undefined") && !!InjectedScriptHost.subtype(object);

/**