Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp

Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp
diff --git a/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp b/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp
index 7ba0a7d08732ac0de8f475cd9b5d68f11b6d8fd9..ca81408c9b708798a328a5b4dc16e10286941ed7 100644
--- a/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp
@@ -30,7 +30,6 @@
#include "core/inspector/v8/InjectedScript.h"
-#include "bindings/core/v8/V8Binding.h"
#include "core/inspector/InspectorTraceEvents.h"
#include "core/inspector/v8/InjectedScriptHost.h"
#include "core/inspector/v8/InjectedScriptManager.h"
@@ -38,6 +37,7 @@
#include "core/inspector/v8/V8Debugger.h"
#include "core/inspector/v8/V8DebuggerClient.h"
#include "core/inspector/v8/V8FunctionCall.h"
+#include "core/inspector/v8/V8StringUtil.h"
#include "platform/JSONParser.h"
#include "platform/JSONValues.h"
#include "platform/JSONValuesForV8.h"
@@ -522,7 +522,7 @@ void InjectedScript::makeCallWithExceptionDetails(V8FunctionCall& function, RefP
v8::Local<v8::Value> resultValue = function.callWithoutExceptionHandling();
if (tryCatch.HasCaught()) {
v8::Local<v8::Message> message = tryCatch.Message();
- String text = !message.IsEmpty() ? toCoreStringWithUndefinedOrNullCheck(message->Get()) : "Internal error";
+ String text = !message.IsEmpty() ? toWTFStringWithTypeCheck(message->Get()) : "Internal error";
*exceptionDetails = TypeBuilder::Debugger::ExceptionDetails::create().setText(text);
} else {
*result = toJSONValue(function.context(), resultValue);

Powered by Google App Engine
This is Rietveld 408576698