third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp - Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

Issue 1650283002: DevTools: remove DOM and Bindings dependencies from inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp ('K') | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8StringUtil.h » ('j') | third_party/WebKit/Source/core/inspector/v8/V8StringUtil.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

index 6be5c93df6bb9832835f2df504f114790e24fbcb..4a8d838a9c77db527d0ae5ba030428ea65c9b0c6 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

@@ -47,6 +47,11 @@ namespace V8RuntimeAgentImplState {

static const char customObjectFormatterEnabled[] = "customObjectFormatterEnabled";

};

+inline static bool asBool(const bool* const b)

+ return b ? *b : false;

PassOwnPtr<V8RuntimeAgent> V8RuntimeAgent::create(InjectedScriptManager* injectedScriptManager, V8Debugger* debugger)

{

return adoptPtr(new V8RuntimeAgentImpl(injectedScriptManager, static_cast<V8DebuggerImpl*>(debugger)));