[DevTools] Option to show device frames in emulation mode

third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
index 79c6098ad465a667674c1ff917d3029fc22e1146..54e46004c7b10cabaf6287785744b8a57782528a 100644
--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
@@ -270,7 +270,8 @@ WebInspector.DeviceModeToolbar.prototype = {
         contextMenu.appendCheckboxItem(WebInspector.UIString("Show throttling"), this._toggleNetworkConditions.bind(this), this._showNetworkConditionsSetting.get(), this._model.type() === WebInspector.DeviceModeModel.Type.None);
         contextMenu.appendCheckboxItem(WebInspector.UIString("Show media queries"), this._toggleMediaInspector.bind(this), this._showMediaInspectorSetting.get(), this._model.type() === WebInspector.DeviceModeModel.Type.None);
         contextMenu.appendCheckboxItem(WebInspector.UIString("Show rulers"), this._toggleRulers.bind(this), this._showRulersSetting.get(), this._model.type() === WebInspector.DeviceModeModel.Type.None);
-        contextMenu.appendSeparator();
+        var deviceOutlineSetting = this._model.deviceOutlineSetting();
+        contextMenu.appendCheckboxItem(WebInspector.UIString("Show device frame"), deviceOutlineSetting.set.bind(deviceOutlineSetting, !deviceOutlineSetting.get()), deviceOutlineSetting.get() && this._model.outlineImage() !== "", !this._model.outlineImage());

[dgozman, 2016/03/21 21:08:38]

Do not alter the disabled/checked state based on the current device mode - it
will confuse users. Copy disabled check from the line above.

[mmccoy, 2016/03/21 22:03:05]

Done.

[dgozman, 2016/03/22 20:30:49]

You should not check this._model.outlineImage() here at all. The checkbox should
not depend on the selected device.

         contextMenu.appendItemsAtLocation("deviceModeMenu");
         contextMenu.appendSeparator();
         contextMenu.appendItem(WebInspector.UIString("Reset to defaults"), this._reset.bind(this));