third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json - Issue 1650243004: [DevTools] Option to show device frames in emulation mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json

Issue 1650243004: [DevTools] Option to show device frames in emulation mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/emulated_devices/nexus_5x_landscape.svg » ('j') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json

diff --git a/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json b/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json

index 438e502a501923cd984605fc9eec4df45da905ce..73c1cfec0f8a9923f51fa4b0f49df2af4d45155c 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json

+++ b/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json

@@ -296,10 +296,22 @@

"screen": {

"device-pixel-ratio": 2.625,

"vertical": {

+ "outline" : {

+ "image": "@url(nexus_5x_portrait.svg) 1x, @url(nexus_5x_portrait.svg) 2x",

+ "insets" : { "left": 20, "top": 88, "right": 0, "bottom": 0 },

+ "width": 454,

+ "height": 921

+ },

"width": 411,

"height": 731

"horizontal": {

+ "outline" : {

+ "image": "@url(nexus_5x_landscape.svg) 1x, @url(nexus_5x_landscape.svg) 2x",

+ "insets" : { "left": 0, "top": 0, "right": 0, "bottom": 0 },

dgozman 2016/02/01 17:18:27 Zero insets are probably wrong.

mmccoy 2016/02/10 20:06:33 Done.

+ "width": 921,

+ "height": 454

+ },

"width": 731,

"height": 411

}