[DevTools] Option to show device frames in emulation mode

third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  */
 WebInspector.EmulatedDevice = function()
 {
     /** @type {string} */
     this.title = "";
     /** @type {string} */
     this.type = WebInspector.EmulatedDevice.Type.Unknown;
     /** @type {!WebInspector.EmulatedDevice.Orientation} */
-    this.vertical = {width: 0, height: 0, outlineInsets: null, outlineImage: null};
+    this.vertical = {width: 0, height: 0, outlineInsets: null, outlineImage: null, outlineWidth: 0, outlineHeight: 0};

[dgozman, 2016/02/01 17:18:27]

I think outlineWidth === width + insets.left + insets.right, so there is no need
to expose it.
Same with height.

[mmccoy, 2016/02/10 20:06:34]

Done!

     /** @type {!WebInspector.EmulatedDevice.Orientation} */
-    this.horizontal = {width: 0, height: 0, outlineInsets: null, outlineImage: null};
+    this.horizontal = {width: 0, height: 0, outlineInsets: null, outlineImage: null, outlineWidth: 0, outlineHeight: 0};
     /** @type {number} */
     this.deviceScaleFactor = 1;
     /** @type {!Array.<string>} */
     this.capabilities = [WebInspector.EmulatedDevice.Capability.Touch, WebInspector.EmulatedDevice.Capability.Mobile];
     /** @type {string} */
     this.userAgent = "";
     /** @type {!Array.<!WebInspector.EmulatedDevice.Mode>} */
     this.modes = [];
 
     /** @type {string} */
     this._show = WebInspector.EmulatedDevice._Show.Default;
     /** @type {boolean} */
     this._showByDefault = true;
 
     /** @type {?Runtime.Extension} */
     this._extension = null;
 }
 
 /** @typedef {!{title: string, orientation: string, insets: !Insets, image: ?string}} */
 WebInspector.EmulatedDevice.Mode;
 
-/** @typedef {!{width: number, height: number, outlineInsets: ?Insets, outlineImage: ?string}} */
+/** @typedef {!{width: number, height: number, outlineInsets: ?Insets, outlineImage: ?string, outlineWidth: ?number, outlineHeight: ?number}} */
 WebInspector.EmulatedDevice.Orientation;
 
 WebInspector.EmulatedDevice.Horizontal = "horizontal";
 WebInspector.EmulatedDevice.Vertical = "vertical";
 
 WebInspector.EmulatedDevice.Type = {
     Phone: "phone",
     Tablet: "tablet",
     Notebook: "notebook",
     Desktop: "desktop",
@@ skipping 75 matching lines @@
             result.height = parseIntValue(json, "height");
             if (result.height < 0 || result.height > WebInspector.DeviceModeModel.MaxDeviceSize || result.height < WebInspector.DeviceModeModel.MinDeviceSize)
                 throw new Error("Emulated device has wrong height: " + result.height);
 
             var outlineInsets = parseValue(json["outline"], "insets", "object", null);
             if (outlineInsets) {
                 result.outlineInsets = parseInsets(outlineInsets);
                 if (result.outlineInsets.left < 0 || result.outlineInsets.top < 0)
                     throw new Error("Emulated device has wrong outline insets");
                 result.outlineImage = /** @type {string} */ (parseValue(json["outline"], "image", "string"));
+                result.outlineWidth = /** @type {number} */ (parseIntValue(json["outline"], "width"));
+                result.outlineHeight = /** @type {number} */ (parseIntValue(json["outline"], "height"));
             }
-
             return /** @type {!WebInspector.EmulatedDevice.Orientation} */ (result);
         }
 
         var result = new WebInspector.EmulatedDevice();
         result.title = /** @type {string} */ (parseValue(json, "title", "string"));
         result.type = /** @type {string} */ (parseValue(json, "type", "string"));
         result.userAgent = /** @type {string} */ (parseValue(json, "user-agent", "string"));
 
         var capabilities = parseValue(json, "capabilities", "object", []);
         if (!Array.isArray(capabilities))
@@ skipping 135 matching lines @@
         var json = {};
         json["width"] = orientation.width;
         json["height"] = orientation.height;
         if (orientation.outlineInsets) {
             json["outline"] = {};
             json["outline"]["insets"] = {};
             json["outline"]["insets"]["left"] = orientation.outlineInsets.left;
             json["outline"]["insets"]["top"] = orientation.outlineInsets.top;
             json["outline"]["insets"]["right"] = orientation.outlineInsets.right;
             json["outline"]["insets"]["bottom"] = orientation.outlineInsets.bottom;
+            json["outline"]["width"] = orientation.outlineWidth;
+            json["outline"]["height"] = orientation.outlineHeight;
             json["outline"]["image"] = orientation.outlineImage;
         }
         return json;
     },
 
     /**
      * @param {!WebInspector.EmulatedDevice.Mode} mode
      * @return {string}
      */
     modeImage: function(mode)
     {
         if (!mode.image)
             return "";
         if (!this._extension)
             return mode.image;
         return this._extension.module().substituteURL(mode.image);
     },
 
     /**
+     * @param {!WebInspector.EmulatedDevice.Mode} mode
+     * @return {string}
+     */
+    outlineImage: function(mode)
+    {
+        var orientation = this.orientationByName(mode.orientation);
+        if (!orientation.outlineImage)
+            return "";
+        if (!this._extension)
+            return orientation.outlineImage;
+        return this._extension.module().substituteURL(orientation.outlineImage);
+    },
+
+    /**
+     * @param {!WebInspector.EmulatedDevice.Mode} mode
+     * @return {Insets|string}

[dgozman, 2016/02/01 17:18:27]

?Insets

[mmccoy, 2016/02/10 20:06:34]

Done

+     */
+    outlineInsets: function(mode)
+    {
+        var orientation = this.orientationByName(mode.orientation);
+        if (!orientation.outlineImage)
+            return "";

[dgozman, 2016/02/01 17:18:27]

return null

[mmccoy, 2016/02/10 20:06:33]

Done.

+        return orientation.outlineInsets;
+    },
+
+    /**
+     * @param {!WebInspector.EmulatedDevice.Mode} mode
+     * @return {Object|string}
+     */
+    outlineDimensions: function(mode)
+    {
+        var orientation = this.orientationByName(mode.orientation);
+        if (!orientation)
+            return "";
+        var dimensions = {
+            "width": orientation.outlineWidth,
+            "height": orientation.outlineHeight
+        }
+        return dimensions;
+    },
+
+    /**
      * @param {string} name
      * @return {!WebInspector.EmulatedDevice.Orientation}
      */
     orientationByName: function(name)
     {
         return name === WebInspector.EmulatedDevice.Vertical ? this.vertical : this.horizontal;
     },
 
     /**
      * @return {boolean}
@@ skipping 169 matching lines @@
             if (deviceById.has(title))
                 to[i].copyShowFrom(/** @type {!WebInspector.EmulatedDevice} */ (deviceById.get(title)));
         }
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
 /** @type {!WebInspector.EmulatedDevicesList} */
 WebInspector.emulatedDevicesList;