|
|
Reverts the revert of 22517.
Rewrites the Mac view resizing logic to have the BrowserWindowController
directly resize and relayout its children views. Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.
BUG=http://crbug.com/17619
TEST=Make sure that views are laid out correctly, even when they change size.
Open and close the bookmark bar. Trigger an infobar and then close it. Trigger
the download shelf and then close it. Trigger a download shelf with the infobar
open, or with the bookmark bar open. Switch to and from fullscreen with various
bars open. Resize the browser window with various bars open. Start the browser
with and without the bookmark bar open. Try all of the above in a popup window.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22721
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+510 lines, -440 lines) |
Patch |
 |
M |
chrome/app/nibs/InfoBarContainer.xib
|
View
|
1
2
|
4 chunks |
+22 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
|
View
|
1
2
|
3 chunks |
+5 lines, -19 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/bookmark_bar_controller.h
|
View
|
1
2
|
4 chunks |
+15 lines, -20 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/bookmark_bar_controller.mm
|
View
|
1
2
|
10 chunks |
+24 lines, -101 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
|
View
|
1
2
|
11 chunks |
+18 lines, -33 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/browser_window_controller.h
|
View
|
1
2
|
3 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/browser_window_controller.mm
|
View
|
1
2
|
15 chunks |
+120 lines, -116 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/browser_window_controller_unittest.mm
|
View
|
1
2
|
3 chunks |
+128 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/download_shelf_controller.h
|
View
|
1
2
|
4 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/download_shelf_controller.mm
|
View
|
1
2
|
4 chunks |
+7 lines, -52 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/download_shelf_mac.mm
|
View
|
1
2
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/download_shelf_mac_unittest.mm
|
View
|
1
2
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
MM |
chrome/browser/cocoa/find_bar_cocoa_controller.h
|
View
|
1
2
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/find_bar_cocoa_controller.mm
|
View
|
1
2
|
1 chunk |
+12 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/infobar_container_controller.h
|
View
|
1
2
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/infobar_container_controller.mm
|
View
|
1
2
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/infobar_container_controller_unittest.mm
|
View
|
1
2
|
3 chunks |
+8 lines, -29 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/toolbar_controller.h
|
View
|
1
2
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/toolbar_controller.mm
|
View
|
1
2
|
5 chunks |
+27 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/cocoa/toolbar_controller_unittest.mm
|
View
|
1
2
|
4 chunks |
+32 lines, -2 lines |
0 comments
|
Download
|
|
A |
chrome/browser/cocoa/view_resizer.h
|
View
|
1
|
1 chunk |
+21 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/cocoa/view_resizer_pong.h
|
View
|
1
|
1 chunk |
+21 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/cocoa/view_resizer_pong.mm
|
View
|
1
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome.gyp
|
View
|
1
2
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
165014:
Reverting 22541. (Closed)
