Chromium Code Reviews| Index: chrome/browser/media/webrtc_logging_handler_host.h |
| diff --git a/chrome/browser/media/webrtc_logging_handler_host.h b/chrome/browser/media/webrtc_logging_handler_host.h |
| index 446d93c546fffd209f4422829c3fdf345f896c45..19ea401b741948ef0f430be4d1653fa79e4f446b 100644 |
| --- a/chrome/browser/media/webrtc_logging_handler_host.h |
| +++ b/chrome/browser/media/webrtc_logging_handler_host.h |
| @@ -81,10 +81,9 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter { |
| typedef base::Callback<void(bool, const std::string&)> GenericDoneCallback; |
| typedef base::Callback<void(bool, const std::string&, const std::string&)> |
| UploadDoneCallback; |
| - typedef base::Callback<void(const std::string&)> |
| - AudioDebugRecordingsErrorCallback; |
| - typedef base::Callback<void(const std::string&, bool, bool)> |
| - AudioDebugRecordingsCallback; |
| + |
| + // Key used to attach the handler to the RenderProcessHost. |
| + static const char kWebRtcLoggingHandlerHostKey[]; |
| WebRtcLoggingHandlerHost(Profile* profile, WebRtcLogUploader* log_uploader); |
| @@ -153,28 +152,6 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter { |
| size_t header_length, |
| size_t packet_length, |
| bool incoming); |
| - |
| - // Starts an audio debug recording. The recording lasts the given |delay|, |
| - // unless |delay| is zero, in which case recording will continue until |
| - // StopAudioDebugRecordings() is explicitly invoked. |
| - // |callback| is invoked once recording stops. If |delay| is zero |
| - // |callback| is invoked once recording starts. |
| - // If a recording was already in progress, |error_callback| is invoked instead |
| - // of |callback|. |
| - void StartAudioDebugRecordings( |
|
Henrik Grunell
2016/02/23 15:29:11
Thanks for moving this out!
terelius-chromium
2016/03/02 10:01:10
Acknowledged.
|
| - content::RenderProcessHost* host, |
| - base::TimeDelta delay, |
| - const AudioDebugRecordingsCallback& callback, |
| - const AudioDebugRecordingsErrorCallback& error_callback); |
| - |
| - // Stops an audio debug recording. |callback| is invoked once recording |
| - // stops. If no recording was in progress, |error_callback| is invoked instead |
| - // of |callback|. |
| - void StopAudioDebugRecordings( |
| - content::RenderProcessHost* host, |
| - const AudioDebugRecordingsCallback& callback, |
| - const AudioDebugRecordingsErrorCallback& error_callback); |
| - |
| private: |
| // States used for protecting from function calls made at non-allowed points |
| // in time. For example, StartLogging() is only allowed in CLOSED state. |
| @@ -261,23 +238,6 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter { |
| bool success, |
| const std::string& error_message); |
| - // Helper for starting audio debug recordings. |
| - void DoStartAudioDebugRecordings( |
| - content::RenderProcessHost* host, |
| - base::TimeDelta delay, |
| - const AudioDebugRecordingsCallback& callback, |
| - const AudioDebugRecordingsErrorCallback& error_callback, |
| - const base::FilePath& log_directory); |
| - |
| - // Helper for stopping audio debug recordings. |
| - void DoStopAudioDebugRecordings( |
| - content::RenderProcessHost* host, |
| - bool is_manual_stop, |
| - uint64_t audio_debug_recordings_id, |
| - const AudioDebugRecordingsCallback& callback, |
| - const AudioDebugRecordingsErrorCallback& error_callback, |
| - const base::FilePath& log_directory); |
| - |
| scoped_ptr<WebRtcLogBuffer> log_buffer_; |
| // The profile associated with our renderer process. |
| @@ -319,12 +279,6 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter { |
| // Ownership lies with the browser process. |
| WebRtcLogUploader* const log_uploader_; |
| - // Must be accessed on the UI thread. |
| - bool is_audio_debug_recordings_in_progress_; |
| - |
| - // This counter allows saving each debug recording in separate files. |
| - uint64_t current_audio_debug_recordings_id_; |
| - |
| DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost); |
| }; |