Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4880)

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h

Issue 1650133002: Start and stop RTC event logs from private extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split the logging handler into one for audio recordings and one for event logs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
index ff5553b98f26ba1a79261650ff7f7648b3c928df..86e5d6663103e928eeccb46e4c95a96a21ada3ca 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
@@ -9,6 +9,8 @@
#include "chrome/browser/extensions/chrome_extension_function.h"
#if defined(ENABLE_WEBRTC)
+#include "chrome/browser/media/audio_debug_recordings_handler.h"
+#include "chrome/browser/media/rtc_event_log_handler.h"
#include "chrome/browser/media/webrtc_logging_handler_host.h"
#endif
#include "chrome/common/extensions/api/webrtc_logging_private.h"
@@ -71,10 +73,10 @@ class WebrtcLoggingPrivateFunctionWithUploadCallback
#endif
};
-class WebrtcLoggingPrivateFunctionWithAudioDebugRecordingsCallback
+class WebrtcLoggingPrivateFunctionWithTimeLimitedRecordingCallback
Henrik Grunell 2016/02/23 15:29:10 Drop "TimeLimited".
terelius-chromium 2016/03/02 10:01:09 Done.
: public WebrtcLoggingPrivateFunction {
protected:
- ~WebrtcLoggingPrivateFunctionWithAudioDebugRecordingsCallback() override {}
+ ~WebrtcLoggingPrivateFunctionWithTimeLimitedRecordingCallback() override {}
#if defined(ENABLE_WEBRTC)
// Must be called on UI thread.
@@ -226,7 +228,7 @@ class WebrtcLoggingPrivateStopRtpDumpFunction
};
class WebrtcLoggingPrivateStartAudioDebugRecordingsFunction
- : public WebrtcLoggingPrivateFunctionWithAudioDebugRecordingsCallback {
+ : public WebrtcLoggingPrivateFunctionWithTimeLimitedRecordingCallback {
public:
DECLARE_EXTENSION_FUNCTION("webrtcLoggingPrivate.startAudioDebugRecordings",
WEBRTCLOGGINGPRIVATE_STARTAUDIODEBUGRECORDINGS)
@@ -240,7 +242,7 @@ class WebrtcLoggingPrivateStartAudioDebugRecordingsFunction
};
class WebrtcLoggingPrivateStopAudioDebugRecordingsFunction
- : public WebrtcLoggingPrivateFunctionWithAudioDebugRecordingsCallback {
+ : public WebrtcLoggingPrivateFunctionWithTimeLimitedRecordingCallback {
public:
DECLARE_EXTENSION_FUNCTION("webrtcLoggingPrivate.stopAudioDebugRecordings",
WEBRTCLOGGINGPRIVATE_STOPAUDIODEBUGRECORDINGS)
@@ -253,6 +255,34 @@ class WebrtcLoggingPrivateStopAudioDebugRecordingsFunction
bool RunAsync() override;
};
+class WebrtcLoggingPrivateStartRtcEventLoggingFunction
+ : public WebrtcLoggingPrivateFunctionWithTimeLimitedRecordingCallback {
+ public:
+ DECLARE_EXTENSION_FUNCTION("webrtcLoggingPrivate.startRtcEventLogging",
+ WEBRTCLOGGINGPRIVATE_STARTRTCEVENTLOGGING)
+ WebrtcLoggingPrivateStartRtcEventLoggingFunction() {}
+
+ private:
+ ~WebrtcLoggingPrivateStartRtcEventLoggingFunction() override {}
+
+ // ExtensionFunction overrides.
+ bool RunAsync() override;
+};
+
+class WebrtcLoggingPrivateStopRtcEventLoggingFunction
+ : public WebrtcLoggingPrivateFunctionWithTimeLimitedRecordingCallback {
+ public:
+ DECLARE_EXTENSION_FUNCTION("webrtcLoggingPrivate.stopRtcEventLogging",
+ WEBRTCLOGGINGPRIVATE_STOPRTCEVENTLOGGING)
+ WebrtcLoggingPrivateStopRtcEventLoggingFunction() {}
+
+ private:
+ ~WebrtcLoggingPrivateStopRtcEventLoggingFunction() override {}
+
+ // ExtensionFunction overrides.
+ bool RunAsync() override;
+};
+
} // namespace extensions
#endif // CHROME_BROWSER_EXTENSIONS_API_WEBRTC_LOGGING_PRIVATE_WEBRTC_LOGGING_PRIVATE_API_H_

Powered by Google App Engine
This is Rietveld 408576698