Chromium Code Reviews| Index: chrome/common/extensions/api/webrtc_logging_private.idl |
| diff --git a/chrome/common/extensions/api/webrtc_logging_private.idl b/chrome/common/extensions/api/webrtc_logging_private.idl |
| index 0f900f944402da663da9706a1914fad707cc5bfa..3c73e354b146a1858e935503e05d527c45787941 100644 |
| --- a/chrome/common/extensions/api/webrtc_logging_private.idl |
| +++ b/chrome/common/extensions/api/webrtc_logging_private.idl |
| @@ -28,23 +28,23 @@ namespace webrtcLoggingPrivate { |
| long? guestProcessId; |
| }; |
| - // This contains information about the result of audio debug recordings. |
| - dictionary AudioDebugRecordingsInfo { |
| + // This contains information about the result of audio debug recordings or |
| + // WebRTC event logs. |
| + dictionary RecordingInfo { |
| // Absolute path prefix for the files with the audio debug recordings. |
| DOMString prefixPath; |
| - // Indicates if recording was stopped. |
| + // Indicates if recording was stopped (either by a timed callback after the |
| + // time limit has elapsed, or by a manual call). |
| boolean didStop; |
| // Indicates if recording was stopped manually through a |
| - // stopAudioDebugRecordings() call. |
| + // stopAudioDebugRecordings() or stopWebRtcEventLogging() call. |
| boolean didManualStop; |
| }; |
| - |
| callback GenericDoneCallback = void (); |
| - callback AudioDebugRecordingsCallback = |
| - void (AudioDebugRecordingsInfo info); |
| + callback RecordingDoneCallback = void (RecordingInfo info); |
| callback UploadDoneCallback = void (UploadResult result); |
| interface Functions { |
| @@ -139,13 +139,33 @@ namespace webrtcLoggingPrivate { |
| static void startAudioDebugRecordings(RequestInfo request, |
| DOMString securityOrigin, |
| long seconds, |
| - AudioDebugRecordingsCallback callback); |
| + RecordingDoneCallback callback); |
| // Stops audio debug recordings. |callback| is invoked once recording |
| // stops. If there is no recording in progress, stopAudioDebugRecordings() |
| // fails. |
| static void stopAudioDebugRecordings(RequestInfo request, |
| DOMString securityOrigin, |
| - AudioDebugRecordingsCallback callback); |
| + RecordingDoneCallback callback); |
| + |
| + // Starts WebRTC event logging. |
| + // startWebRtcEventLogging() logs the most recent events that happened before |
|
Henrik Grunell
2016/03/10 21:33:34
Over 80 cols?
terelius-chromium
2016/03/24 16:21:22
Done.
|
| + // the call, and then keep logging for |seconds| seconds into the future. |
| + // |callback| is invoked once the logging stops. |
| + // If |seconds| is zero, the logging will continue until |
| + // stopWebRtcEventLogging() is explicitly called. In this case, |
| + // |callback| is invoked once recording starts and will report |
| + // that recording has not stopped. |
| + // If |seconds| is negative, startWebRtcEventLogging() fails. |
| + static void startWebRtcEventLogging(RequestInfo request, |
| + DOMString securityOrigin, |
| + long seconds, |
| + RecordingDoneCallback callback); |
| + |
| + // Stops RTC event logging. |callback| is invoked once the logging stops. |
| + // If there is no recording in progress, stopWebRtcEventLogging() fails. |
| + static void stopWebRtcEventLogging(RequestInfo request, |
| + DOMString securityOrigin, |
| + RecordingDoneCallback callback); |
| }; |
| }; |