Start and stop RTC event logs from private extension API.

chrome/browser/media/audio_debug_recordings_handler.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MEDIA_AUDIO_DEBUG_RECORDINGS_HANDLER_H_
+#define CHROME_BROWSER_MEDIA_AUDIO_DEBUG_RECORDINGS_HANDLER_H_
+
+#include <stddef.h>
+#include <stdint.h>
+
+#include "base/macros.h"
+#include "build/build_config.h"
+#include "content/public/browser/browser_message_filter.h"

[Henrik Grunell, 2016/02/23 15:29:10]

Remove. Seems like other includes could be removed too. Check all the new files.

[terelius-chromium, 2016/03/02 10:01:10]

Done.

+#include "content/public/browser/render_process_host.h"
+#include "net/base/network_interfaces.h"
+
+class Profile;
+
+// AudioDebugRecordingsHandler provides an interface to the internal logs
+// in WebRTC:
+// - Starts and stops AudioDebugRecordings, aka AEC dumps.
+// - Starts and stops RTC event logs.

[Guido Urdaneta, 2016/02/23 13:57:34]

This class is only for AudioDebugRecordings.
Should the class be called WebRtcAudioDebugRecordingsHandler to emphasize that
this is related to WebRTC?

[Henrik Grunell, 2016/02/23 15:29:10]

It's not strictly WebRTC since it also does recording of audio data independent
of WebRTC (mic input). I think the name should be kept as is.

[Henrik Grunell, 2016/02/23 15:29:10]

Remove comment about RTC event log. :) Actually, rewrite the comment since it's
only one bullet left.

[terelius-chromium, 2016/03/02 10:01:10]

Done.

+class AudioDebugRecordingsHandler
+    : public base::RefCountedThreadSafe<AudioDebugRecordingsHandler> {
+ public:
+  typedef base::Callback<void(bool, const std::string&)> GenericDoneCallback;
+  typedef base::Callback<void(const std::string&)>
+      TimeLimitedRecordingErrorCallback;

[Henrik Grunell, 2016/02/23 15:29:10]

Drop "TimeLimited".

[terelius-chromium, 2016/03/02 10:01:10]

Done. Changed to RecordingErrorCallback and RecordingDoneCallback.
(RecordingDoneCallback for consistency with the existing GenericDoneCallback and
UploadDoneCallback.)

+  typedef base::Callback<void(const std::string&, bool, bool)>
+      TimeLimitedRecordingCallback;
+
+  // Key used to attach the handler to the RenderProcessHost
+  static const char kAudioDebugRecordingsHandlerKey[];
+
+  explicit AudioDebugRecordingsHandler(Profile* profile);
+
+  // Starts an audio debug recording. The recording lasts the given |delay|,
+  // unless |delay| is zero, in which case recording will continue until
+  // StopAudioDebugRecordings() is explicitly invoked.
+  // |callback| is invoked once recording stops. If |delay| is zero
+  // |callback| is invoked once recording starts.
+  // If a recording was already in progress, |error_callback| is invoked instead
+  // of |callback|.
+  void StartAudioDebugRecordings(
+      content::RenderProcessHost* host,
+      base::TimeDelta delay,
+      const TimeLimitedRecordingCallback& callback,
+      const TimeLimitedRecordingErrorCallback& error_callback);
+
+  // Stops an audio debug recording. |callback| is invoked once recording
+  // stops. If no recording was in progress, |error_callback| is invoked instead
+  // of |callback|.
+  void StopAudioDebugRecordings(
+      content::RenderProcessHost* host,
+      const TimeLimitedRecordingCallback& callback,
+      const TimeLimitedRecordingErrorCallback& error_callback);
+
+ private:
+  friend class content::BrowserThread;

[Henrik Grunell, 2016/02/23 15:29:10]

Not sure why these friends are needed. Can be removed?

[terelius-chromium, 2016/03/02 10:01:10]

Based on a comment in base/memory/ref_counted.h, I believe
friend class base::RefCountedThreadSafe<AudioDebugRecordingsHandler>;
is recommended unless you provide a custom Traits class.
I removed the others.

[Henrik Grunell, 2016/03/10 21:33:34]

Acknowledged.

+  friend class base::DeleteHelper<AudioDebugRecordingsHandler>;
+  friend class base::RefCountedThreadSafe<AudioDebugRecordingsHandler>;
+
+  virtual ~AudioDebugRecordingsHandler();
+
+  base::FilePath GetLogDirectoryAndEnsureExists();
+
+  // Helper for starting audio debug recordings.
+  void DoStartAudioDebugRecordings(
+      content::RenderProcessHost* host,
+      base::TimeDelta delay,
+      const TimeLimitedRecordingCallback& callback,
+      const TimeLimitedRecordingErrorCallback& error_callback,
+      const base::FilePath& log_directory);
+
+  // Helper for stopping audio debug recordings.
+  void DoStopAudioDebugRecordings(
+      content::RenderProcessHost* host,
+      bool is_manual_stop,
+      uint64_t audio_debug_recordings_id,
+      const TimeLimitedRecordingCallback& callback,
+      const TimeLimitedRecordingErrorCallback& error_callback,
+      const base::FilePath& log_directory);
+
+  // The profile associated with our renderer process.
+  Profile* const profile_;
+
+  // Must be accessed on the UI thread.
+  bool is_audio_debug_recordings_in_progress_;
+
+  // This counter allows saving each debug recording in separate files.
+  uint64_t current_audio_debug_recordings_id_;
+
+  DISALLOW_COPY_AND_ASSIGN(AudioDebugRecordingsHandler);
+};
+
+#endif  // CHROME_BROWSER_MEDIA_AUDIO_DEBUG_RECORDINGS_HANDLER_H_