Start and stop RTC event logs from private extension API.

chrome/browser/media/audio_debug_recordings_handler.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/audio_debug_recordings_handler.h"
+
+#include <string>
+#include <utility>
+
+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/files/file_util.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/time/time.h"
+#include "chrome/browser/media/webrtc_log_list.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_switches.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/render_process_host.h"
+
+using content::BrowserThread;
+
+// Keys used to attach handler to the RenderProcessHost
+const char AudioDebugRecordingsHandler::kAudioDebugRecordingsHandlerKey[] =
+    "kAudioDebugRecordingsHandlerKey";
+
+namespace {
+
+// Returns a path name to be used as prefix for audio debug recordings files.
+base::FilePath GetAudioDebugRecordingsPrefixPath(
+    const base::FilePath& directory,
+    uint64_t audio_debug_recordings_id) {
+  static const char kAudioDebugRecordingsFilePrefix[] = "AudioDebugRecordings.";
+  return directory.AppendASCII(kAudioDebugRecordingsFilePrefix +
+                               base::Int64ToString(audio_debug_recordings_id));
+}
+
+}  // namespace
+
+AudioDebugRecordingsHandler::AudioDebugRecordingsHandler(Profile* profile)
+    : profile_(profile),
+      is_audio_debug_recordings_in_progress_(false),
+      current_audio_debug_recordings_id_(0) {
+  DCHECK(profile_);
+}
+
+AudioDebugRecordingsHandler::~AudioDebugRecordingsHandler() {
+}
+
+void AudioDebugRecordingsHandler::StartAudioDebugRecordings(
+    content::RenderProcessHost* host,
+    base::TimeDelta delay,
+    const RecordingDoneCallback& callback,
+    const RecordingErrorCallback& error_callback) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  BrowserThread::PostTaskAndReplyWithResult(
+      BrowserThread::FILE, FROM_HERE,
+      base::Bind(&AudioDebugRecordingsHandler::GetLogDirectoryAndEnsureExists,
+                 this),
+      base::Bind(&AudioDebugRecordingsHandler::DoStartAudioDebugRecordings,
+                 this, host, delay, callback, error_callback));
+}
+
+void AudioDebugRecordingsHandler::StopAudioDebugRecordings(
+    content::RenderProcessHost* host,
+    const RecordingDoneCallback& callback,
+    const RecordingErrorCallback& error_callback) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  BrowserThread::PostTaskAndReplyWithResult(
+      BrowserThread::FILE, FROM_HERE,
+      base::Bind(&AudioDebugRecordingsHandler::GetLogDirectoryAndEnsureExists,
+                 this),
+      base::Bind(&AudioDebugRecordingsHandler::DoStopAudioDebugRecordings, this,
+                 host, true /* manual stop */,

[tommi (sloooow) - chröme, 2016/04/07 12:44:29]

nit: we usually don't use these kinds of comments (and very rarely /* */ style
commenting).  If you want to keep the comment, consider //
Same for other instances of the same.

[terelius-chromium, 2016/04/13 08:52:05]

I added a variable is_manual_stop = true; to make it clear what "true" means in
this context. Similarly in the rest of the file and in
webrtc_event_log_handler.cc

+                 current_audio_debug_recordings_id_, callback, error_callback));
+}
+
+base::FilePath AudioDebugRecordingsHandler::GetLogDirectoryAndEnsureExists() {
+  DCHECK_CURRENTLY_ON(BrowserThread::FILE);
+  base::FilePath log_dir_path =
+      WebRtcLogList::GetWebRtcLogDirectoryForProfile(profile_->GetPath());
+  base::File::Error error;
+  if (!base::CreateDirectoryAndGetError(log_dir_path, &error)) {
+    DLOG(ERROR) << "Could not create WebRTC log directory, error: " << error;
+    return base::FilePath();
+  }
+  return log_dir_path;
+}
+
+void AudioDebugRecordingsHandler::DoStartAudioDebugRecordings(
+    content::RenderProcessHost* host,
+    base::TimeDelta delay,
+    const RecordingDoneCallback& callback,
+    const RecordingErrorCallback& error_callback,
+    const base::FilePath& log_directory) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  if (is_audio_debug_recordings_in_progress_) {
+    error_callback.Run("Audio debug recordings already in progress");
+    return;
+  }
+
+  is_audio_debug_recordings_in_progress_ = true;
+  base::FilePath prefix_path = GetAudioDebugRecordingsPrefixPath(
+      log_directory, ++current_audio_debug_recordings_id_);
+  host->EnableAudioDebugRecordings(prefix_path);
+
+  if (delay.is_zero()) {
+    callback.Run(prefix_path.AsUTF8Unsafe(), false /* not stopped */,
+                 false /* not manually stopped */);
+    return;
+  }
+
+  BrowserThread::PostDelayedTask(
+      BrowserThread::UI, FROM_HERE,
+      base::Bind(&AudioDebugRecordingsHandler::DoStopAudioDebugRecordings, this,
+                 host, false /* no manual stop */,
+                 current_audio_debug_recordings_id_, callback, error_callback,
+                 log_directory),
+      delay);
+}
+
+void AudioDebugRecordingsHandler::DoStopAudioDebugRecordings(
+    content::RenderProcessHost* host,
+    bool is_manual_stop,
+    uint64_t audio_debug_recordings_id,
+    const RecordingDoneCallback& callback,
+    const RecordingErrorCallback& error_callback,
+    const base::FilePath& log_directory) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK_LE(audio_debug_recordings_id, current_audio_debug_recordings_id_);
+
+  base::FilePath prefix_path = GetAudioDebugRecordingsPrefixPath(
+      log_directory, audio_debug_recordings_id);
+  // Prevent an old posted StopAudioDebugRecordings() call to stop a newer dump.
+  // This could happen in a sequence like:
+  //   Start(10);  //Start dump 1. Post Stop() to run after 10 seconds.

[tommi (sloooow) - chröme, 2016/04/07 12:44:29]

nit: space after//

[terelius-chromium, 2016/04/13 08:52:05]

Done.

+  //   Stop();  // Manually stop dump 1 before 10 seconds;
+  //   Start(20);  // Start dump 2. Posted Stop() for 1 should not stop dump 2.
+  if (audio_debug_recordings_id < current_audio_debug_recordings_id_) {
+    callback.Run(prefix_path.AsUTF8Unsafe(), false /* not stopped */,
+                 is_manual_stop);
+    return;
+  }
+
+  if (!is_audio_debug_recordings_in_progress_) {
+    error_callback.Run("No audio debug recording in progress");
+    return;
+  }
+
+  host->DisableAudioDebugRecordings();
+  is_audio_debug_recordings_in_progress_ = false;
+  callback.Run(prefix_path.AsUTF8Unsafe(), true /* stopped */, is_manual_stop);
+}