Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1650113002: Print a message when DM finishes (Closed)

Created:
4 years, 10 months ago by scroggo
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Print a message when DM finishes When running from the command line, it is obvious when DM finishes, since it brings the prompt back up. But in XCode, it just sits there, so my glance doesn't let me know that it's finished. Make it more obvious that DM is done. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650113002 Committed: https://skia.googlesource.com/skia/+/4d9eaea1740568548c7a954fdc3b4f7ee8df1e49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
4 years, 10 months ago (2016-01-29 15:19:43 UTC) #3
mtklein
lgtm
4 years, 10 months ago (2016-01-29 15:23:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650113002/1
4 years, 10 months ago (2016-01-29 15:27:00 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 15:48:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4d9eaea1740568548c7a954fdc3b4f7ee8df1e49

Powered by Google App Engine
This is Rietveld 408576698