Add a data_dep for osmesa to //ui/gl and run ui_unittests.

Always build osmesa (on Linux) and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

Also, make osmesa test-only.

R=jamesr@chromium.org, jeffbrown@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/ab52142d7b4058a8d5952ad624ff8ecd3fb606ec

[viettrungluu, 2016-01-29 02:07:10]

Description was changed from

==========
Add a data_dep for osmesa to //ui/gl and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

I wonder if osmesa now builds on Android ... and if the tests will
run/pass on Android.

R=jeffbrown@google.com
==========

to

==========
Add a data_dep for osmesa to //ui/gl and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

I wonder if osmesa now builds on Android ... and if the tests will
run/pass on Android.

R=jeffbrown@google.com,jamesr@chromium.org
==========

[viettrungluu, 2016-01-29 02:07:10]

viettrungluu@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2016-01-29 02:10:31]

Even if it linked on android I'm not sure it would perform well enough to want
to actually use.

is there a test-only target we can put this in? It's a data_deps so it won't be
linked in but a build of only production targets shouldn't need to build osmesa
at all.  I'd prefer to mark osmesa testonly so it isn't accidentally linked into
a prod target.

[viettrungluu, 2016-01-29 02:19:46]

On 2016/01/29 02:10:31, jamesr wrote:
> Even if it linked on android I'm not sure it would perform well enough to want
> to actually use.

I mostly have no idea what happens when you tell the native viewport service to
use it on Android (or how things previously passed)....

> is there a test-only target we can put this in? It's a data_deps so it won't
be
> linked in but a build of only production targets shouldn't need to build
osmesa
> at all.  I'd prefer to mark osmesa testonly so it isn't accidentally linked
into
> a prod target.

I don't know of an obvious one. (You can pick a somewhat arbitrary one, but it's
a bit weird -- since it's a runtime dependence of the native viewport service,
not of any test itself.)

Ideally, osmesa would be a "loadable module" (hence never actually linked), but
last I checked that didn't actually exist.

We could also add a dependency at the "top" (for some definition of "top") level
(and those groups are marked test-only, since they include tests)....

[jamesr, 2016-01-29 02:36:01]

Can't it be a data_dep of ui_unittests since that's what actually uses it?  If
that's too weird then a top-level-ish testonly dep would be better

Re android - things previously passed by running on a real device with real GL.
we don't run tests in virtualized linux envs. We do run tests on headless linux
boxes (VMs) where real GL doesn't work, hence the need for osmesa

[viettrungluu, 2016-01-29 17:32:39]

On 2016/01/29 02:36:01, jamesr wrote:
> Can't it be a data_dep of ui_unittests since that's what actually uses it?  If
> that's too weird then a top-level-ish testonly dep would be better

ui_unittests doesn't really use it per se. It'd be just as happy to run with
real GL. It's just that we want (if only to avoid windows popping up)/need (on
bots) to run it with mesa when running it in an automated way.

I'll just stick in the //BUILD.gn's :default group (for lack of a better place).

> Re android - things previously passed by running on a real device with real
GL.
> we don't run tests in virtualized linux envs. We do run tests on headless
linux
> boxes (VMs) where real GL doesn't work, hence the need for osmesa

Well, that doesn't a priori explain why things work with the flags that are
passed....

[viettrungluu, 2016-01-29 17:37:57]

Description was changed from

==========
Add a data_dep for osmesa to //ui/gl and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

I wonder if osmesa now builds on Android ... and if the tests will
run/pass on Android.

R=jeffbrown@google.com,jamesr@chromium.org
==========

to

==========
Always build osmesa (on Linux) and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

Also, make osmesa test-only.

R=jeffbrown@google.com,jamesr@chromium.org
==========

[viettrungluu, 2016-01-29 17:38:32]

ptal

[jamesr, 2016-01-29 18:04:44]

lgtm

[viettrungluu, 2016-01-29 18:11:25]

Description was changed from

==========
Always build osmesa (on Linux) and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

Also, make osmesa test-only.

R=jeffbrown@google.com,jamesr@chromium.org
==========

to

==========
Always build osmesa (on Linux) and run ui_unittests.

(The only (?) dep to osmesa was removed in
28dd561326b6d885e105e6bfa34f9b2770ce3910.)

Also, make osmesa test-only.

R=jamesr@chromium.org, jeffbrown@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/ab52142d7b4058a8d5952ad624f...
==========

[viettrungluu, 2016-01-29 18:11:27]

Committed patchset #2 (id:20001) manually as
ab52142d7b4058a8d5952ad624ff8ecd3fb606ec (presubmit successful).