third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp - Issue 1649983003: Remove the forced layout in getComputedStyle for elements in Shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp

Issue 1649983003: Remove the forced layout in getComputedStyle for elements in Shadow DOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Look at ShadowRoots when walking up the tree in updateLayoutTreeForNodeIfNeeded. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.h ('K') | « third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.h ('k') | third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.h » ('j') | third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp

diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp

index d85de7c5422f036ea56b88424930f45f673dbb99..f68c2bbe1b765fca9625520dc5ebb3544510346e 100644

--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp

+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp

@@ -44,13 +44,6 @@ static bool isLayoutObjectReparented(const LayoutObject* layoutObject)

return false;

}

-void ParentDetails::didTraverseInsertionPoint(const InsertionPoint* insertionPoint)

- if (!m_insertionPoint) {

- m_insertionPoint = insertionPoint;

- }

ContainerNode* parent(const Node& node, ParentDetails* details)

{

// TODO(hayato): Uncomment this once we can be sure LayoutTreeBuilderTraversal::parent() is used only for a node in a document.