third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 1649983003: Remove the forced layout in getComputedStyle for elements in Shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 1649983003: Remove the forced layout in getComputedStyle for elements in Shadow DOM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Look at ShadowRoots when walking up the tree in updateLayoutTreeForNodeIfNeeded. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index 0c3dda6c8401ab771c079841d111cfb583c0b6a5..836a3452fa0527266ecdddb62a5b05aeb3d91188 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -565,7 +565,6 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValu

style = computeComputedStyle();

bool forceFullLayout = isLayoutDependent(propertyID, style, layoutObject)

- || styledNode->isInShadowTree()

|| (document.ownerElement() && document.ensureStyleResolver().hasViewportDependentMediaQueries());

if (forceFullLayout) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/ElementResolveContext.cpp » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')