Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: lib/shelf_web_socket.dart

Issue 1649903002: Provide a WebSocketChannel. (Closed) Base URL: git@github.com:dart-lang/shelf_web_socket@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | lib/src/web_socket_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/shelf_web_socket.dart
diff --git a/lib/shelf_web_socket.dart b/lib/shelf_web_socket.dart
index 0866f1f91e8ed5628ad68d39a25e0d49c8060408..e233cce6a7e040bf54e5d5641fce8a4474c4ca15 100644
--- a/lib/shelf_web_socket.dart
+++ b/lib/shelf_web_socket.dart
@@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'package:http_parser/http_parser.dart';
import 'package:shelf/shelf.dart';
import 'src/web_socket_handler.dart';
@@ -20,8 +21,8 @@ typedef _BinaryFunction(arg1, arg2);
/// This means that this can be placed first in a [Cascade] and only upgrade
/// requests will be handled.
///
-/// The [onConnection] must take a [CompatibleWebSocket] as its first argument.
-/// It may also take a string, the [WebSocket subprotocol][], as its second
+/// The [onConnection] must take a [WebSocketChannel] as its first argument. It
+/// may also take a string, the [WebSocket subprotocol][], as its second
/// argument. The subprotocol is determined by looking at the client's
/// `Sec-WebSocket-Protocol` header and selecting the first entry that also
/// appears in [protocols]. If no subprotocols are shared between the client and
« no previous file with comments | « CHANGELOG.md ('k') | lib/src/web_socket_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698