Refactor code for resynthesizing references in summaries.

Refactor code for resynthesizing references in summaries.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e9a86b2555104905b41a0dfa0c530ba0df1a7286

[Paul Berry, 2016-01-28 22:40:08]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-01-28 22:52:52]

LGTM

https://codereview.chromium.org/1649893002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1649893002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1443: * referred to by this
[_ReferenceInfo] to some type parameters.  The type
I guess the "apply" operation is commutative, but it seems more logical to say
that we apply type _arguments_ to the referred entity.

https://codereview.chromium.org/1649893002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1465: DartType
_buildType(DartType getTypeParameter(int i)) {
Would it be better to name this function "getTypeArgument"?

[Paul Berry, 2016-01-28 23:05:57]

https://codereview.chromium.org/1649893002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1649893002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1443: * referred to by this
[_ReferenceInfo] to some type parameters.  The type
On 2016/01/28 22:52:51, scheglov wrote:
> I guess the "apply" operation is commutative, but it seems more logical to say
> that we apply type _arguments_ to the referred entity.

Done.

https://codereview.chromium.org/1649893002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1465: DartType
_buildType(DartType getTypeParameter(int i)) {
On 2016/01/28 22:52:51, scheglov wrote:
> Would it be better to name this function "getTypeArgument"?

Done.

[Paul Berry, 2016-01-28 23:12:56]

Description was changed from

==========
Refactor code for resynthesizing references in summaries.
==========

to

==========
Refactor code for resynthesizing references in summaries.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e9a86b2555104905b41a0dfa0c530ba0df1a7286
==========

[Paul Berry, 2016-01-28 23:12:58]

Committed patchset #1 (id:1) manually as
e9a86b2555104905b41a0dfa0c530ba0df1a7286 (presubmit successful).