Issue 164983007: Refactor CollectionIndexCache for clarity and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164983007: Refactor CollectionIndexCache for clarity and performance (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
esprehn, adamk, eseidel

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactor CollectionIndexCache for clarity and performance Refactor CollectionIndexCache for clarity and performance: - Split nodeBeforeOrAfterCachedNode() method into nodeBeforeCachedNode() nodeAfterCachedNode(). - Simplify and inline isLastNodeCloserThanLastOrCachedNode() / isFirstNodeCloserThanCachedNode() code. - Simplify a lot the branching in nodeAt(). - In nodeAt(), handle the case where the cache is valid first as it is more common and handle all cases where the cache is valid together (i.e index == cachedIndex, index < cachedIndex, index > cachedIndex). - Comment the code for clarity. The Bindings/node-list-access.html is 2-3% faster with this patch. This CL is based on the following WebKit revision by <antti@apple.com>;: http://trac.webkit.org/changeset/158698 R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167230