Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 164983006: Remove dead code in media galleries file system registry. (Closed)

Created:
6 years, 10 months ago by vandebo (ex-Chrome)
Modified:
6 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Remove dead code in media galleries file system registry. Since adding the preferences observer, RevokeOldGalleries() has been dead code. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251541

Patch Set 1 #

Patch Set 2 : retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M chrome/browser/media_galleries/media_file_system_registry.cc View 4 chunks +1 line, -25 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vandebo (ex-Chrome)
6 years, 10 months ago (2014-02-14 19:50:35 UTC) #1
Lei Zhang
lgtm
6 years, 10 months ago (2014-02-14 20:34:39 UTC) #2
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-14 21:57:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/164983006/30001
6 years, 10 months ago (2014-02-14 22:04:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 00:56:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264772
6 years, 10 months ago (2014-02-15 00:56:45 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-15 00:58:12 UTC) #7
Lei Zhang
On 2014/02/15 00:56:45, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-15 00:58:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/164983006/30001
6 years, 10 months ago (2014-02-15 01:12:23 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 03:05:31 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264938
6 years, 10 months ago (2014-02-15 03:05:34 UTC) #11
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-15 03:08:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/164983006/30001
6 years, 10 months ago (2014-02-15 03:09:14 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 05:32:35 UTC) #14
Message was sent while issue was closed. 
Change committed as 251541

Powered by Google App Engine
This is Rietveld 408576698