Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1649823002: Roll Dart forward and use the shared vmservice isolate sources + benchmark fixes (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Roll Dart forward and use the shared vmservice isolate sources + benchmark fixes BUG= R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7d6b3eb5828a54391854afc4f862e33b5ad4b7d2

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -300 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/BUILD.gn View 1 1 chunk +11 lines, -6 lines 0 comments Download
M mojo/dart/embedder/vmservice.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D mojo/dart/embedder/vmservice/loader.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/dart/embedder/vmservice/main.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/dart/embedder/vmservice/server.dart View 1 chunk +0 lines, -208 lines 0 comments Download
M mojo/tools/data/benchmarks View 1 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 10 months ago (2016-02-01 21:24:48 UTC) #4
zra
lgtm
4 years, 10 months ago (2016-02-01 21:35:11 UTC) #5
Cutch
4 years, 10 months ago (2016-02-01 21:39:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7d6b3eb5828a54391854afc4f862e33b5ad4b7d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698