Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/gn/command_gen.cc

Issue 1649783003: Port "Eclipse CDT settings" file generation from GYP to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index b4faaa59a5e5710f2b6fdc4fcb8a58134ca7c6a1..9b7fee974e9592a07d098bc0a0d1b16ad3e2fc8c 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -10,6 +10,7 @@
#include "base/timer/elapsed_timer.h"
#include "tools/gn/build_settings.h"
#include "tools/gn/commands.h"
+#include "tools/gn/eclipse_writer.h"
#include "tools/gn/ninja_target_writer.h"
#include "tools/gn/ninja_writer.h"
#include "tools/gn/runtime_deps.h"
@@ -26,6 +27,7 @@ namespace {
const char kSwitchCheck[] = "check";
const char kSwitchIde[] = "ide";
+const char kSwitchIdeValueEclipse[] = "eclipse";
const char kSwitchIdeValueVs[] = "vs";
// Called on worker thread to write the ninja file.
@@ -151,8 +153,16 @@ bool RunIdeWriter(const std::string& ide,
const BuildSettings* build_settings,
Builder* builder,
Err* err) {
- if (ide == kSwitchIdeValueVs) {
- base::ElapsedTimer timer;
+ base::ElapsedTimer timer;
+ if (ide == kSwitchIdeValueEclipse) {
+ bool res = EclipseWriter::RunAndWriteFile(build_settings, builder, err);
+ if (res) {
+ OutputString("Generating Eclipse settings took " +
+ base::Int64ToString(timer.Elapsed().InMilliseconds()) +
+ "ms\n");
+ }
+ return res;
+ } else if (ide == kSwitchIdeValueVs) {
bool res =
VisualStudioWriter::RunAndWriteFiles(build_settings, builder, err);
if (res &&
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/eclipse_writer.h » ('j') | tools/gn/eclipse_writer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698