Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4306)

Unified Diff: chrome/test/remoting/webapp_javascript_unittest.cc

Issue 1649683002: Disable QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/remoting/webapp_javascript_unittest.cc
diff --git a/chrome/test/remoting/webapp_javascript_unittest.cc b/chrome/test/remoting/webapp_javascript_unittest.cc
index 676daa9f155dd1c5a9811937b94a6b0e94dc4bc3..d04f261a760541d84d97187d33f51f4fb72599c9 100644
--- a/chrome/test/remoting/webapp_javascript_unittest.cc
+++ b/chrome/test/remoting/webapp_javascript_unittest.cc
@@ -13,14 +13,10 @@
namespace remoting {
// Flakily times out on Win7 Tests (dbg) and Linux Tests (dbg)(1):
-// https://crbug.com/504204.
-#if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(NDEBUG)
-#define MAYBE_Remoting_Webapp_Js_Unittest DISABLED_Remoting_Webapp_Js_Unittest
-#else
-#define MAYBE_Remoting_Webapp_Js_Unittest Remoting_Webapp_Js_Unittest
-#endif
+// https://crbug.com/504204. Recently completely broken on
+// Linux: https://crbug.com/582005
IN_PROC_BROWSER_TEST_F(QUnitBrowserTestRunner,
- MAYBE_Remoting_Webapp_Js_Unittest) {
+ DISABLED_Remoting_Webapp_Js_Unittest) {
base::FilePath base_dir;
ASSERT_TRUE(PathService::Get(base::DIR_EXE, &base_dir));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698