Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1649653004: [heap] Refactor IncrementalMarking::Stop(). (Closed)

Created:
4 years, 10 months ago by Hannes Payer (out of office)
Modified:
4 years, 10 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Refactor IncrementalMarking::Stop(). BUG= Committed: https://crrev.com/87b6e8806f450c3c0ade1ebec668b2323b06e8d4 Cr-Commit-Position: refs/heads/master@{#33593}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M src/heap/incremental-marking.cc View 2 chunks +1 line, -21 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
Hannes Payer (out of office)
4 years, 10 months ago (2016-01-28 15:10:15 UTC) #2
Hannes Payer (out of office)
4 years, 10 months ago (2016-01-28 16:21:19 UTC) #4
ulan
https://codereview.chromium.org/1649653004/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (left): https://codereview.chromium.org/1649653004/diff/1/src/heap/incremental-marking.cc#oldcode955 src/heap/incremental-marking.cc:955: p->ClearFlag(Page::RESCAN_ON_EVACUATION); Without this code, the flag becomes sticky, i.e. ...
4 years, 10 months ago (2016-01-28 16:41:24 UTC) #5
Hannes Payer (out of office)
Large pages will never have this flag set. The change is intended.
4 years, 10 months ago (2016-01-28 16:49:52 UTC) #6
ulan
lgtm
4 years, 10 months ago (2016-01-28 16:52:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649653004/1
4 years, 10 months ago (2016-01-28 16:52:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 16:58:07 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:58:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87b6e8806f450c3c0ade1ebec668b2323b06e8d4
Cr-Commit-Position: refs/heads/master@{#33593}

Powered by Google App Engine
This is Rietveld 408576698