Src-ify Android Tests.

Src-ify Android Tests.

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873
Committed: https://crrev.com/4abea28bed4a20fb89a1fc65eafcfb772ce0ca0f
Cr-Commit-Position: refs/heads/master@{#372108}

[ghost stip (do not use), 2016-01-28 00:50:03]

Description was changed from

==========
Src-ify Android Tests.

BUG=525873
==========

to

==========
Src-ify Android Tests.

BUG=525873
==========

[ghost stip (do not use), 2016-01-28 00:50:03]

stip@chromium.org changed reviewers:
+ dpranke@chromium.org, jbudorick@chromium.org

[ghost stip (do not use), 2016-01-28 00:52:00]

Description was changed from

==========
Src-ify Android Tests.

BUG=525873
==========

to

==========
Src-ify Android Tests.

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873
==========

[ghost stip (do not use), 2016-01-28 00:52:28]

ptal

[jbudorick, 2016-01-28 00:56:10]

https://codereview.chromium.org/1649593002/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1649593002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:146: "test": "base_unittests"
non-swarming tests don't use the wrapper scripts at the moment, so you have to
pass the --isolate-file-path explicitly:
https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/c...

[ghost stip (do not use), 2016-01-28 01:09:46]

updated, ptal

[jbudorick, 2016-01-28 01:11:58]

lgtm

I'm guessing you're going to address the instrumentation tests separately?

[ghost stip (do not use), 2016-01-28 01:21:26]

yeah, I haven't src-ed them yet. my initial goal is to get a few gtests running
in production

[Dirk Pranke, 2016-01-28 01:26:09]

lgtm

[jbudorick, 2016-01-28 04:27:37]

https://codereview.chromium.org/1649593002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1649593002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:240:
"--isolate_file_path=src/ui/base/ui_base_unittests.isolate"
this should be ui_base_tests.isolate

https://codereview.chromium.org/1649593002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:372:
"--isolate_file_path=src/ui/base/ui_base_unittests.isolate"
same

[ghost stip (do not use), 2016-01-28 07:51:26]

https://codereview.chromium.org/1649593002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1649593002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:240:
"--isolate_file_path=src/ui/base/ui_base_unittests.isolate"
On 2016/01/28 04:27:37, jbudorick wrote:
> this should be ui_base_tests.isolate

Done.

https://codereview.chromium.org/1649593002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:372:
"--isolate_file_path=src/ui/base/ui_base_unittests.isolate"
On 2016/01/28 04:27:37, jbudorick wrote:
> same

Done.

[ghost stip (do not use), 2016-01-28 07:51:47]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 07:52:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649593002/40001

[tandrii(chromium), 2016-01-28 08:13:03]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-01-28 08:13:03]

lgtm

[ghost stip (do not use), 2016-01-28 08:15:04]

The CQ bit was unchecked by stip@chromium.org

[ghost stip (do not use), 2016-01-28 08:15:16]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2016-01-28 08:15:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1649593002/#ps40001
(title: "Fix isolate file.")

[commit-bot: I haz the power, 2016-01-28 08:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649593002/40001

[commit-bot: I haz the power, 2016-01-28 08:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 08:39:31]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ghost stip (do not use), 2016-01-28 08:42:51]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-01-28 08:43:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649593002/40001

[commit-bot: I haz the power, 2016-01-28 10:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 10:26:15]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tandrii(chromium), 2016-01-28 10:34:51]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-01-28 10:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649593002/40001

[tandrii(chromium), 2016-01-28 10:36:25]

The failure both time is the same, but i have no idea as to why. I've
reluctantly scheduled 3rd cq run, but I suspect the test is genuinely failing,
and maybe it's mistakenly enabled in this CL.

[commit-bot: I haz the power, 2016-01-28 12:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 12:06:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ghost stip (do not use), 2016-01-28 15:59:18]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-01-28 16:00:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649593002/40001

[commit-bot: I haz the power, 2016-01-28 16:50:57]

Description was changed from

==========
Src-ify Android Tests.

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873
==========

to

==========
Src-ify Android Tests.

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873
==========

[commit-bot: I haz the power, 2016-01-28 16:50:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 16:52:06]

Description was changed from

==========
Src-ify Android Tests.

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873
==========

to

==========
Src-ify Android Tests.

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873

Committed: https://crrev.com/4abea28bed4a20fb89a1fc65eafcfb772ce0ca0f
Cr-Commit-Position: refs/heads/master@{#372108}
==========

[commit-bot: I haz the power, 2016-01-28 16:52:06]

Patchset 3 (id:??) landed as
https://crrev.com/4abea28bed4a20fb89a1fc65eafcfb772ce0ca0f
Cr-Commit-Position: refs/heads/master@{#372108}

[ghost stip (do not use), 2016-01-28 16:53:22]

4th time's the charm

[tandrii(chromium), 2016-01-28 17:03:09]

On 2016/01/28 16:53:22, stip wrote:
> 4th time's the charm

:(((

[ghost stip (do not use), 2016-01-28 17:40:37]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1643803004/ by stip@chromium.org.

The reason for reverting is: build presubmit flake broke the build side test, so
we can't double test. will reland later.