Issue 1649533005: Compute literal constant values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1649533005: Compute literal constant values. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/summary/resynthesize.dart	View		6 chunks	+122 lines, -3 lines	0 comments	Download
	M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View		5 chunks	+54 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

lgtm, with the understanding that calling ConstantEvaluationEngine from the resynthesizer is a temporary measure, and ...

4 years, 10 months ago (2016-01-28 19:31:14 UTC) #2

scheglov

4 years, 10 months ago (2016-01-28 19:33:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
425cd5444e88b131a564451c9e27b3f59b7da324 (presubmit successful).