Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 164953003: Remove hardcoded "Preferences" strings from app_list tests (Closed)

Created:
6 years, 10 months ago by gab
Modified:
6 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove hardcoded "Preferences" strings from app_list tests R=tapted BUG=343692 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
gab
6 years, 10 months ago (2014-02-13 23:12:43 UTC) #1
tapted
lgtm thanks
6 years, 10 months ago (2014-02-13 23:24:03 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 10 months ago (2014-02-14 00:18:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/164953003/1
6 years, 10 months ago (2014-02-14 00:20:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 01:02:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263949
6 years, 10 months ago (2014-02-14 01:02:44 UTC) #6
gab
The CQ bit was checked by gab@chromium.org
6 years, 10 months ago (2014-02-14 05:08:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/164953003/1
6 years, 10 months ago (2014-02-14 05:09:01 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:01:14 UTC) #9
Message was sent while issue was closed. 
Change committed as 251300

Powered by Google App Engine
This is Rietveld 408576698