fixes inferring () -> <bottom> in strong mode

fixes inferring () -> <bottom> in strong mode
This fixes https://github.com/dart-lang/dev_compiler/issues/47

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/88dbb006c52ecd483d284159b240a3b422ec0982

[Jennifer Messerly, 2016-01-27 22:17:57]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2016-01-27 22:18:23]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-02-01 19:33:47]

Friendly ping :)

[vsm, 2016-02-01 20:51:17]

lgtm

https://codereview.chromium.org/1649523002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1649523002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1601:
(/*info:DYNAMIC_INVOKE*/h.foo());
another test:

void foo(int f(Object _)) {}
...
foo((x) => null);
foo((x) => throw "not implemented");

Should work - and I think it works because you're substituting bottom with
dynamic instead of Object.

[Jennifer Messerly, 2016-02-01 20:59:29]

Thanks!

https://codereview.chromium.org/1649523002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1649523002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1601:
(/*info:DYNAMIC_INVOKE*/h.foo());
On 2016/02/01 20:51:17, vsm wrote:
> another test:
> 
> void foo(int f(Object _)) {}
> ...
> foo((x) => null);
> foo((x) => throw "not implemented");
> 
> Should work - and I think it works because you're substituting bottom with
> dynamic instead of Object.

Done.

[Jennifer Messerly, 2016-02-01 21:30:26]

Description was changed from

==========
fixes inferring () -> <bottom> in strong mode
This fixes https://github.com/dart-lang/dev_compiler/issues/47
==========

to

==========
fixes inferring () -> <bottom> in strong mode
This fixes https://github.com/dart-lang/dev_compiler/issues/47

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/88dbb006c52ecd483d284159b240a3b422ec0982
==========

[Jennifer Messerly, 2016-02-01 21:30:28]

Committed patchset #3 (id:60001) manually as
88dbb006c52ecd483d284159b240a3b422ec0982 (presubmit successful).