Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1649513002:
Add WebRTC support in ChromotingClient (Closed)
|
Created:
4 years, 11 months ago by Sergey Ulanov Modified:
4 years, 10 months ago Reviewers:
Jamie CC:
chromium-reviews, chromoting-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@trans_con_life Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd WebRTC support in ChromotingClient
Now ChromotingClient creates WebrtcConnectionToHost or
IceConnectionToHost depending on protocol_config.
BUG=547158
Committed: https://crrev.com/41c0b663733f8a463e3d1ff22e710932a8476273
Cr-Commit-Position: refs/heads/master@{#372204}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 #
Messages
Total messages: 23 (13 generated)
sergeyu@chromium.org changed reviewers: + jamiewalch@chromium.org
Reviewing now, but s/No/Now/ and s/create/creates/ in the CL description, please.
lgtm
Description was changed from ========== Add WebRTC support in ChromotingClient No ChromotingClient create WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 ========== to ========== Add WebRTC support in ChromotingClient Now ChromotingClient creates WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 ==========
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by sergeyu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamiewalch@chromium.org Link to the patchset: https://codereview.chromium.org/1649513002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649513002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649513002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by sergeyu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamiewalch@chromium.org Link to the patchset: https://codereview.chromium.org/1649513002/#ps50003 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649513002/50003 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649513002/50003
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sergeyu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamiewalch@chromium.org Link to the patchset: https://codereview.chromium.org/1649513002/#ps90001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649513002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649513002/90001
Message was sent while issue was closed.
Description was changed from ========== Add WebRTC support in ChromotingClient Now ChromotingClient creates WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 ========== to ========== Add WebRTC support in ChromotingClient Now ChromotingClient creates WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:90001)
Message was sent while issue was closed.
Description was changed from ========== Add WebRTC support in ChromotingClient Now ChromotingClient creates WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 ========== to ========== Add WebRTC support in ChromotingClient Now ChromotingClient creates WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 Committed: https://crrev.com/41c0b663733f8a463e3d1ff22e710932a8476273 Cr-Commit-Position: refs/heads/master@{#372204} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/41c0b663733f8a463e3d1ff22e710932a8476273 Cr-Commit-Position: refs/heads/master@{#372204} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
