Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1649503002: Move SkAvoidXfermode over from Android (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -0 lines) Patch
A gm/avoidxfermode.cpp View 1 1 chunk +99 lines, -0 lines 0 comments Download
M gyp/effects.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A include/effects/SkAvoidXfermode.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A src/effects/SkAvoidXfermode.cpp View 1 1 chunk +177 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
robertphillips
I will move the .h & .cpp once the platform-specific location CL lands.
4 years, 10 months ago (2016-01-28 20:06:18 UTC) #4
reed1
lgtm
4 years, 10 months ago (2016-01-28 21:05:17 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649503002/40001
4 years, 10 months ago (2016-01-29 13:20:36 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 13:50:27 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649503002/20001
4 years, 10 months ago (2016-01-29 16:12:52 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 16:36:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649503002/20001
4 years, 10 months ago (2016-01-29 16:43:28 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 16:44:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2a1d401bf2d500bab225b78a20cb6f16b2c67efb

Powered by Google App Engine
This is Rietveld 408576698