Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1649493005: Work around exasperating Google3 Android build error. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/core/SkXfermode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649493005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649493005/1
4 years, 10 months ago (2016-01-28 18:10:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 18:22:39 UTC) #5
dogben
4 years, 10 months ago (2016-01-28 18:23:19 UTC) #7
reed1
lgtm
4 years, 10 months ago (2016-01-28 20:51:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649493005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649493005/1
4 years, 10 months ago (2016-01-28 20:54:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/900901fb1ba5170549670829fc8f9d9b590ff5f0
4 years, 10 months ago (2016-01-28 20:55:36 UTC) #13
mtklein
wtf, lgtm
4 years, 10 months ago (2016-01-28 22:02:28 UTC) #14
dogben
4 years, 10 months ago (2016-02-03 23:59:59 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1669663003/ by benjaminwagner@google.com.

The reason for reverting is: This workaround no longer seems to be necessary..

Powered by Google App Engine
This is Rietveld 408576698