Speculative fix for crash during browser startup with opaque frame.

Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky

Committed: https://crrev.com/17257534a482124490589598423d0178977c63ea
Cr-Commit-Position: refs/heads/master@{#371970}

[Peter Kasting, 2016-01-28 01:18:06]

Description was changed from

==========
Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
==========

to

==========
Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky
==========

[Peter Kasting, 2016-01-28 01:18:06]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2016-01-28 01:18:20]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649493003/1

[commit-bot: I haz the power, 2016-01-28 02:24:55]

Description was changed from

==========
Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky
==========

to

==========
Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky
==========

[commit-bot: I haz the power, 2016-01-28 02:24:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 02:26:09]

Description was changed from

==========
Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky
==========

to

==========
Speculative fix for crash during browser startup with opaque frame.

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky

Committed: https://crrev.com/17257534a482124490589598423d0178977c63ea
Cr-Commit-Position: refs/heads/master@{#371970}
==========

[commit-bot: I haz the power, 2016-01-28 02:26:10]

Patchset 1 (id:??) landed as
https://crrev.com/17257534a482124490589598423d0178977c63ea
Cr-Commit-Position: refs/heads/master@{#371970}

[sky, 2016-01-28 02:57:01]

LGTM