Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1649483002: Revert of Aura on Android: content/browser (Closed)

Created:
4 years, 11 months ago by mfomitchev
Modified:
4 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, zea+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, tim+watch_chromium.org, nona+watch_chromium.org, aboxhall+watch_chromium.org, jam, jbauman+watch_chromium.org, pvalenzuela+watch_chromium.org, je_julie, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, kalyank, creis+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, plundblad+watch_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, nektar+watch_chromium.org, yurys, plaree+watch_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_select_file
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Aura on Android: content/browser (patchset #9 id:160001 of https://codereview.chromium.org/1411503005/ ) Reason for revert: Reverting, since Android Aura has been cancelled. Original issue's description: > Aura on Android: content/browser > > Changes necessary to get content/browser, content/public/browser, and content/child GN targets to build. > > BUG=507792 > > Committed: https://crrev.com/841f818387cab380b6b21158ad94c9b256bb9c32 > Cr-Commit-Position: refs/heads/master@{#358496} TBR=sievers@chromium.org,dmazzoni@chromium.org,dsinclair@chromium.org,simonhatch@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=507792 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/2b8b066ae1cf604c750a95b17584eb2ee505c597 Cr-Commit-Position: refs/heads/master@{#372136}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Updated media_web_contents_observer.cc #

Patch Set 5 : Removed a TODO #

Total comments: 4

Patch Set 6 : Merging android_non_aura_browser_sources into android_browser_sources rather than private_browser_s… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -169 lines) Patch
M components/tracing/trace_config_file.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/trace_config_file.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 chunks +5 lines, -13 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 5 chunks +8 lines, -13 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/content_video_view.cc View 1 2 chunks +3 lines, -10 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 5 chunks +4 lines, -5 lines 0 comments Download
M content/browser/browser_main_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/compositor/surface_utils.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/power_save_blocker_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 5 chunks +5 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 5 chunks +6 lines, -9 lines 0 comments Download
M content/child/BUILD.gn View 1 3 chunks +7 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 chunks +58 lines, -66 lines 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1646693002 Patch 100001

Messages

Total messages: 15 (4 generated)
mfomitchev
Created Revert of Aura on Android: content/browser
4 years, 11 months ago (2016-01-27 21:21:48 UTC) #1
DaleCurtis
PowerSave blocker stuff from WebContentsImpl has moved to MediaWebContentsObserver.
4 years, 11 months ago (2016-01-27 21:23:22 UTC) #3
mfomitchev
On 2016/01/27 21:23:22, DaleCurtis wrote: > PowerSave blocker stuff from WebContentsImpl has moved to > ...
4 years, 11 months ago (2016-01-27 22:58:48 UTC) #5
mfomitchev
https://codereview.chromium.org/1649483002/diff/330001/content/content_browser.gypi File content/content_browser.gypi (left): https://codereview.chromium.org/1649483002/diff/330001/content/content_browser.gypi#oldcode1710 content/content_browser.gypi:1710: 'browser/compositor/browser_compositor_overlay_candidate_validator_android.cc', @sievers: Does this seem okay (since compositor_browser_sources is ...
4 years, 11 months ago (2016-01-27 23:00:51 UTC) #6
no sievers
https://codereview.chromium.org/1649483002/diff/330001/content/content_browser.gypi File content/content_browser.gypi (right): https://codereview.chromium.org/1649483002/diff/330001/content/content_browser.gypi#newcode536 content/content_browser.gypi:536: 'browser/compositor/browser_compositor_overlay_candidate_validator_android.cc', On 2016/01/27 23:00:51, mfomitchev wrote: > @sivers: does ...
4 years, 11 months ago (2016-01-27 23:08:06 UTC) #7
mfomitchev
sievers: Can you please take another look? https://codereview.chromium.org/1649483002/diff/330001/content/content_browser.gypi File content/content_browser.gypi (right): https://codereview.chromium.org/1649483002/diff/330001/content/content_browser.gypi#newcode536 content/content_browser.gypi:536: 'browser/compositor/browser_compositor_overlay_candidate_validator_android.cc', On ...
4 years, 11 months ago (2016-01-28 00:20:31 UTC) #8
no sievers
lgtm
4 years, 11 months ago (2016-01-28 01:28:47 UTC) #9
shatch
components/tracing lgtm
4 years, 10 months ago (2016-01-28 15:13:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649483002/350001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649483002/350001
4 years, 10 months ago (2016-01-28 15:23:48 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:350001)
4 years, 10 months ago (2016-01-28 19:23:22 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 19:24:18 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/2b8b066ae1cf604c750a95b17584eb2ee505c597
Cr-Commit-Position: refs/heads/master@{#372136}

Powered by Google App Engine
This is Rietveld 408576698