Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 16494002: Expand overloaded methods and optional parameters in the html library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index e7681fea5018b590d01caab725aea63a8a0d9693..1297006e1d528a3a9e87b994b9da7600db87e634 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -1436,19 +1436,13 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
@DocsEditable
CanvasGradient createLinearGradient(num x0, num y0, num x1, num y1) native "CanvasRenderingContext2D_createLinearGradient_Callback";
- CanvasPattern createPattern(canvas_OR_image, String repetitionType) {
- if ((repetitionType is String || repetitionType == null) && (canvas_OR_image is CanvasElement || canvas_OR_image == null)) {
- return _createPattern_1(canvas_OR_image, repetitionType);
- }
- if ((repetitionType is String || repetitionType == null) && (canvas_OR_image is ImageElement || canvas_OR_image == null)) {
- return _createPattern_2(canvas_OR_image, repetitionType);
- }
- throw new ArgumentError("Incorrect number or type of arguments");
- }
-
- CanvasPattern _createPattern_1(canvas_OR_image, repetitionType) native "CanvasRenderingContext2D__createPattern_1_Callback";
+ @DomName('CanvasRenderingContext2D.createPattern')
+ @DocsEditable
+ CanvasPattern createPattern(CanvasElement canvas, String repetitionType) native "CanvasRenderingContext2D_createPattern_Callback";
- CanvasPattern _createPattern_2(canvas_OR_image, repetitionType) native "CanvasRenderingContext2D__createPattern_2_Callback";
+ @DomName('CanvasRenderingContext2D.createPatternFromImage')
+ @DocsEditable
+ CanvasPattern createPatternFromImage(ImageElement image, String repetitionType) native "CanvasRenderingContext2D_createPatternFromImage_Callback";
@DomName('CanvasRenderingContext2D.createRadialGradient')
@DocsEditable
@@ -6806,21 +6800,13 @@ class DataTransferItemList extends NativeFieldWrapperClass1 {
@DocsEditable
int get length native "DataTransferItemList_length_Getter";
- void add(data_OR_file, [String type]) {
- if ((data_OR_file is File || data_OR_file == null) && type == null) {
- _add_1(data_OR_file);
- return;
- }
- if ((type is String || type == null) && (data_OR_file is String || data_OR_file == null)) {
- _add_2(data_OR_file, type);
- return;
- }
- throw new ArgumentError("Incorrect number or type of arguments");
- }
-
- void _add_1(data_OR_file) native "DataTransferItemList__add_1_Callback";
+ @DomName('DataTransferItemList.add')
+ @DocsEditable
+ void add(String data, String type) native "DataTransferItemList_add_Callback";
- void _add_2(data_OR_file, type) native "DataTransferItemList__add_2_Callback";
+ @DomName('DataTransferItemList.addFile')
+ @DocsEditable
+ void addFile(File file) native "DataTransferItemList_addFile_Callback";
@DomName('DataTransferItemList.clear')
@DocsEditable
@@ -17317,7 +17303,7 @@ class Navigator extends NativeFieldWrapperClass1 {
* window.navigator.getUserMedia(audio: true, video: true).then((stream) {
* var video = new VideoElement()
* ..autoplay = true
- * ..src = Url.createObjectUrl(stream);
+ * ..src = Url.createObjectUrlFromStream(stream);
* document.body.append(video);
* });
*
@@ -19941,33 +19927,21 @@ class RtcDataChannel extends EventTarget {
@DocsEditable
void $dom_removeEventListener(String type, EventListener listener, [bool useCapture]) native "RTCDataChannel_removeEventListener_Callback";
- void send(data) {
- if ((data is TypedData || data == null)) {
- _send_1(data);
- return;
- }
- if ((data is ByteBuffer || data == null)) {
- _send_2(data);
- return;
- }
- if ((data is Blob || data == null)) {
- _send_3(data);
- return;
- }
- if ((data is String || data == null)) {
- _send_4(data);
- return;
- }
- throw new ArgumentError("Incorrect number or type of arguments");
- }
-
- void _send_1(data) native "RTCDataChannel__send_1_Callback";
+ @DomName('RTCDataChannel.send')
+ @DocsEditable
+ void send(String data) native "RTCDataChannel_send_Callback";
- void _send_2(data) native "RTCDataChannel__send_2_Callback";
+ @DomName('RTCDataChannel.sendBlob')
+ @DocsEditable
+ void sendBlob(Blob data) native "RTCDataChannel_sendBlob_Callback";
- void _send_3(data) native "RTCDataChannel__send_3_Callback";
+ @DomName('RTCDataChannel.sendByteBuffer')
+ @DocsEditable
+ void sendByteBuffer(ByteBuffer data) native "RTCDataChannel_sendByteBuffer_Callback";
- void _send_4(data) native "RTCDataChannel__send_4_Callback";
+ @DomName('RTCDataChannel.sendTypedData')
+ @DocsEditable
+ void sendTypedData(TypedData data) native "RTCDataChannel_sendTypedData_Callback";
@DomName('RTCDataChannel.onclose')
@DocsEditable
@@ -23143,7 +23117,7 @@ class TextAreaElement extends _Element_Merged {
@DocsEditable
void setCustomValidity(String error) native "HTMLTextAreaElement_setCustomValidity_Callback";
- void setRangeText(String replacement, [int start, int end, String selectionMode]) {
+ void setRangeText(String replacement, {int start, int end, String selectionMode}) {
if ((replacement is String || replacement == null) && start == null && end == null && selectionMode == null) {
_setRangeText_1(replacement);
return;
@@ -24236,24 +24210,17 @@ class UnknownElement extends _Element_Merged {
class Url extends NativeFieldWrapperClass1 {
Url.internal();
- static String createObjectUrl(blob_OR_source_OR_stream) {
- if ((blob_OR_source_OR_stream is MediaSource || blob_OR_source_OR_stream == null)) {
- return _createObjectURL_1(blob_OR_source_OR_stream);
- }
- if ((blob_OR_source_OR_stream is MediaStream || blob_OR_source_OR_stream == null)) {
- return _createObjectURL_2(blob_OR_source_OR_stream);
- }
- if ((blob_OR_source_OR_stream is Blob || blob_OR_source_OR_stream == null)) {
- return _createObjectURL_3(blob_OR_source_OR_stream);
- }
- throw new ArgumentError("Incorrect number or type of arguments");
- }
-
- static String _createObjectURL_1(blob_OR_source_OR_stream) native "URL__createObjectURL_1_Callback";
+ @DomName('URL.createObjectURL')
+ @DocsEditable
+ static String createObjectUrl(MediaSource source) native "URL_createObjectURL_Callback";
- static String _createObjectURL_2(blob_OR_source_OR_stream) native "URL__createObjectURL_2_Callback";
+ @DomName('URL.createObjectUrlFromBlob')
+ @DocsEditable
+ static String createObjectUrlFromBlob(Blob blob) native "URL_createObjectUrlFromBlob_Callback";
- static String _createObjectURL_3(blob_OR_source_OR_stream) native "URL__createObjectURL_3_Callback";
+ @DomName('URL.createObjectUrlFromStream')
+ @DocsEditable
+ static String createObjectUrlFromStream(MediaStream stream) native "URL_createObjectUrlFromStream_Callback";
@DomName('URL.revokeObjectURL')
@DocsEditable

Powered by Google App Engine
This is Rietveld 408576698